From: Wolfgang Grandegger <wg@grandegger.com>
To: ajneu <ajneu1@gmail.com>, linux-can@vger.kernel.org
Cc: Stephane Grosjean <s.grosjean@peak-system.com>
Subject: Re: Bug? -- NEVER getting controller-problem{back-to-error-active}
Date: Mon, 20 Jun 2016 16:28:21 +0200 [thread overview]
Message-ID: <5767FD85.9020701@grandegger.com> (raw)
In-Reply-To: <loom.20160620T154404-130@post.gmane.org>
hello,
Am 20.06.2016 um 15:53 schrieb ajneu:
> Wolfgang Grandegger <wg <at> grandegger.com> writes:
>
>>
>>
>> Am 20.06.2016 um 15:00 schrieb ajneu:
>>> Hi Wolfgang,
>>>
>>> yes wonderful: you patch works (and solves both issues)!
>>> Will it be going into the mainline linux kernel?
>>
>> I'm going to prepare a patch for mainline inclusion. Can I add your
>> "Tested-by: ajneu <ajneu1 <at> gmail.com>"?
>
> Well ok, you may.
> (Just note I only tested the bugs I reported, and can confirm: those bugs
> are gone. I cannot account for any side-effects, since I didn't do any
> "complete" tests. But scanning the code (*briefly*) it looks sortof ok...
Yes, the changes are obvious. Don't understand why
CAN_STATE_ERROR_ACTIVE is handled differently. I have added the author.
> Just question: Your change eliminates
> dev->can.state = CAN_STATE_ERROR_ACTIVE;
> where dev references usb_if, which is passed into the function as parameter.
> Is it ok to eliminate that call??
> (Perhaps its equiv to the line
> can_change_state(netdev, cf, tx_state, rx_state);
> which is called somewhat lower???)
The state is set in can_change_state().:
http://lxr.free-electrons.com/source/drivers/net/can/dev.c#L341
Wolfgang.
next prev parent reply other threads:[~2016-06-20 14:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 9:12 Bug? -- NEVER getting controller-problem{back-to-error-active} ajneu
2016-06-20 9:22 ` ajneu
2016-06-20 10:33 ` Wolfgang Grandegger
2016-06-20 12:41 ` ajneu
2016-06-20 13:00 ` ajneu
2016-06-20 13:31 ` Wolfgang Grandegger
2016-06-20 13:53 ` ajneu
2016-06-20 14:28 ` Wolfgang Grandegger [this message]
2016-06-21 8:29 ` Stephane Grosjean
2016-06-21 9:58 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5767FD85.9020701@grandegger.com \
--to=wg@grandegger.com \
--cc=ajneu1@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=s.grosjean@peak-system.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.