From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org
Cc: g.liakhovetski@gmx.de
Subject: Re: [PATCH 3/6] v4l: Add packed Bayer raw12 pixel formats
Date: Mon, 20 Jun 2016 18:37:49 +0300 [thread overview]
Message-ID: <57680DCD.1000902@linux.intel.com> (raw)
In-Reply-To: <576809F1.1010507@xs4all.nl>
Hi Hans,
Thanks for the review!
Hans Verkuil wrote:
> On 05/27/2016 02:44 PM, Sakari Ailus wrote:
>> These formats are compressed 12-bit raw bayer formats with four different
>> pixel orders. They are similar to 10-bit variants. The formats added by
>> this patch are
>>
>> V4L2_PIX_FMT_SBGGR12P
>> V4L2_PIX_FMT_SGBRG12P
>> V4L2_PIX_FMT_SGRBG12P
>> V4L2_PIX_FMT_SRGGB12P
>>
>> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>> ---
>> .../DocBook/media/v4l/pixfmt-srggb12p.xml | 103 +++++++++++++++++++++
>> Documentation/DocBook/media/v4l/pixfmt.xml | 1 +
>> include/uapi/linux/videodev2.h | 5 +
>> 3 files changed, 109 insertions(+)
>> create mode 100644 Documentation/DocBook/media/v4l/pixfmt-srggb12p.xml
>>
>> diff --git a/Documentation/DocBook/media/v4l/pixfmt-srggb12p.xml b/Documentation/DocBook/media/v4l/pixfmt-srggb12p.xml
>> new file mode 100644
>> index 0000000..affa366
>> --- /dev/null
>> +++ b/Documentation/DocBook/media/v4l/pixfmt-srggb12p.xml
>> @@ -0,0 +1,103 @@
>> + <refentry id="pixfmt-srggb12p">
>> + <refmeta>
>> + <refentrytitle>V4L2_PIX_FMT_SRGGB12P ('pRCC'),
>> + V4L2_PIX_FMT_SGRBG12P ('pgCC'),
>> + V4L2_PIX_FMT_SGBRG12P ('pGCC'),
>> + V4L2_PIX_FMT_SBGGR12P ('pBCC'),
>
> Nitpick: the last comma should be removed otherwise the title would end with it.
>
> Looks good otherwise.
>
> With the comma removed:
>
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Indeed. Looks like this comes from the 10-bit definitions. I'll fix that
one as well.
--
Sakari Ailus
sakari.ailus@linux.intel.com
next prev parent reply other threads:[~2016-06-20 15:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 12:44 [PATCH 0/6] New raw bayer format definitions, fixes Sakari Ailus
2016-05-27 12:44 ` [PATCH 1/6] v4l: Correct the ordering of LSBs of the 10-bit raw packed formats Sakari Ailus
2016-06-20 15:12 ` Hans Verkuil
2016-06-20 15:34 ` Sakari Ailus
2016-05-27 12:44 ` [PATCH 2/6] v4l: Fix number of zeroed high order bits in 12-bit raw format defs Sakari Ailus
2016-06-20 15:13 ` Hans Verkuil
2016-05-27 12:44 ` [PATCH 3/6] v4l: Add packed Bayer raw12 pixel formats Sakari Ailus
2016-06-20 15:21 ` Hans Verkuil
2016-06-20 15:37 ` Sakari Ailus [this message]
2016-05-27 12:44 ` [PATCH 4/6] media: Add 1X14 14-bit raw bayer media bus code definitions Sakari Ailus
2016-06-20 15:23 ` Hans Verkuil
2016-05-27 12:44 ` [PATCH 5/6] v4l: Add 14-bit raw bayer pixel format definitions Sakari Ailus
2016-06-20 15:24 ` Hans Verkuil
2016-06-20 16:03 ` Sakari Ailus
2016-06-20 16:05 ` Hans Verkuil
2016-05-27 12:44 ` [PATCH 6/6] v4l: Add packed Bayer raw14 pixel formats Sakari Ailus
2016-06-20 15:29 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57680DCD.1000902@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=g.liakhovetski@gmx.de \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.