From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rYFgd1c3hzDqCX for ; Tue, 21 Jun 2016 01:50:36 +1000 (AEST) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u5KFmOf4077200 for ; Mon, 20 Jun 2016 11:50:34 -0400 Received: from e32.co.us.ibm.com (e32.co.us.ibm.com [32.97.110.150]) by mx0a-001b2d01.pphosted.com with ESMTP id 23n2f0gcd4-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 20 Jun 2016 11:50:34 -0400 Received: from localhost by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 20 Jun 2016 09:50:33 -0600 Subject: Re: [PATCH] ibmvnic: fix to use list_for_each_safe() when delete items To: weiyj_lk@163.com, John Allen , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman References: <1466218408-20940-1-git-send-email-weiyj_lk@163.com> Cc: netdev@vger.kernel.org, Wei Yongjun , linuxppc-dev@lists.ozlabs.org From: Thomas Falcon Date: Mon, 20 Jun 2016 10:50:26 -0500 MIME-Version: 1.0 In-Reply-To: <1466218408-20940-1-git-send-email-weiyj_lk@163.com> Content-Type: text/plain; charset=utf-8 Message-Id: <576810C2.6080208@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 06/17/2016 09:53 PM, weiyj_lk@163.com wrote: > From: Wei Yongjun > > Since we will remove items off the list using list_del() we need > to use a safe version of the list_for_each() macro aptly named > list_for_each_safe(). > > Signed-off-by: Wei Yongjun > --- > drivers/net/ethernet/ibm/ibmvnic.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c > index 864cb21..0b6a922 100644 > --- a/drivers/net/ethernet/ibm/ibmvnic.c > +++ b/drivers/net/ethernet/ibm/ibmvnic.c > @@ -3141,14 +3141,14 @@ static void handle_request_ras_comp_num_rsp(union ibmvnic_crq *crq, > > static void ibmvnic_free_inflight(struct ibmvnic_adapter *adapter) > { > - struct ibmvnic_inflight_cmd *inflight_cmd; > + struct ibmvnic_inflight_cmd *inflight_cmd, *tmp1; > struct device *dev = &adapter->vdev->dev; > - struct ibmvnic_error_buff *error_buff; > + struct ibmvnic_error_buff *error_buff, *tmp2; > unsigned long flags; > unsigned long flags2; > > spin_lock_irqsave(&adapter->inflight_lock, flags); > - list_for_each_entry(inflight_cmd, &adapter->inflight, list) { > + list_for_each_entry_safe(inflight_cmd, tmp1, &adapter->inflight, list) { > switch (inflight_cmd->crq.generic.cmd) { > case LOGIN: > dma_unmap_single(dev, adapter->login_buf_token, > @@ -3165,8 +3165,8 @@ static void ibmvnic_free_inflight(struct ibmvnic_adapter *adapter) > break; > case REQUEST_ERROR_INFO: > spin_lock_irqsave(&adapter->error_list_lock, flags2); > - list_for_each_entry(error_buff, &adapter->errors, > - list) { > + list_for_each_entry_safe(error_buff, tmp2, > + &adapter->errors, list) { > dma_unmap_single(dev, error_buff->dma, > error_buff->len, > DMA_FROM_DEVICE); > Thanks! Acked-by: Thomas Falcon > > > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Falcon Subject: Re: [PATCH] ibmvnic: fix to use list_for_each_safe() when delete items Date: Mon, 20 Jun 2016 10:50:26 -0500 Message-ID: <576810C2.6080208@linux.vnet.ibm.com> References: <1466218408-20940-1-git-send-email-weiyj_lk@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: netdev@vger.kernel.org, Wei Yongjun , linuxppc-dev@lists.ozlabs.org To: weiyj_lk@163.com, John Allen , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Return-path: In-Reply-To: <1466218408-20940-1-git-send-email-weiyj_lk@163.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: netdev.vger.kernel.org T24gMDYvMTcvMjAxNiAwOTo1MyBQTSwgd2VpeWpfbGtAMTYzLmNvbSB3cm90ZToKPiBGcm9tOiBX ZWkgWW9uZ2p1biA8eW9uZ2p1bl93ZWlAdHJlbmRtaWNyby5jb20uY24+Cj4KPiBTaW5jZSB3ZSB3 aWxsIHJlbW92ZSBpdGVtcyBvZmYgdGhlIGxpc3QgdXNpbmcgbGlzdF9kZWwoKSB3ZSBuZWVkCj4g dG8gdXNlIGEgc2FmZSB2ZXJzaW9uIG9mIHRoZSBsaXN0X2Zvcl9lYWNoKCkgbWFjcm8gYXB0bHkg bmFtZWQKPiBsaXN0X2Zvcl9lYWNoX3NhZmUoKS4KPgo+IFNpZ25lZC1vZmYtYnk6IFdlaSBZb25n anVuIDx5b25nanVuX3dlaUB0cmVuZG1pY3JvLmNvbS5jbj4KPiAtLS0KPiAgZHJpdmVycy9uZXQv ZXRoZXJuZXQvaWJtL2libXZuaWMuYyB8IDEwICsrKysrLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQs IDUgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L25ldC9ldGhlcm5ldC9pYm0vaWJtdm5pYy5jIGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvaWJtL2li bXZuaWMuYwo+IGluZGV4IDg2NGNiMjEuLjBiNmE5MjIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9u ZXQvZXRoZXJuZXQvaWJtL2libXZuaWMuYwo+ICsrKyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L2li bS9pYm12bmljLmMKPiBAQCAtMzE0MSwxNCArMzE0MSwxNCBAQCBzdGF0aWMgdm9pZCBoYW5kbGVf cmVxdWVzdF9yYXNfY29tcF9udW1fcnNwKHVuaW9uIGlibXZuaWNfY3JxICpjcnEsCj4gIAo+ICBz dGF0aWMgdm9pZCBpYm12bmljX2ZyZWVfaW5mbGlnaHQoc3RydWN0IGlibXZuaWNfYWRhcHRlciAq YWRhcHRlcikKPiAgewo+IC0Jc3RydWN0IGlibXZuaWNfaW5mbGlnaHRfY21kICppbmZsaWdodF9j bWQ7Cj4gKwlzdHJ1Y3QgaWJtdm5pY19pbmZsaWdodF9jbWQgKmluZmxpZ2h0X2NtZCwgKnRtcDE7 Cj4gIAlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmYWRhcHRlci0+dmRldi0+ZGV2Owo+IC0Jc3RydWN0 IGlibXZuaWNfZXJyb3JfYnVmZiAqZXJyb3JfYnVmZjsKPiArCXN0cnVjdCBpYm12bmljX2Vycm9y X2J1ZmYgKmVycm9yX2J1ZmYsICp0bXAyOwo+ICAJdW5zaWduZWQgbG9uZyBmbGFnczsKPiAgCXVu c2lnbmVkIGxvbmcgZmxhZ3MyOwo+ICAKPiAgCXNwaW5fbG9ja19pcnFzYXZlKCZhZGFwdGVyLT5p bmZsaWdodF9sb2NrLCBmbGFncyk7Cj4gLQlsaXN0X2Zvcl9lYWNoX2VudHJ5KGluZmxpZ2h0X2Nt ZCwgJmFkYXB0ZXItPmluZmxpZ2h0LCBsaXN0KSB7Cj4gKwlsaXN0X2Zvcl9lYWNoX2VudHJ5X3Nh ZmUoaW5mbGlnaHRfY21kLCB0bXAxLCAmYWRhcHRlci0+aW5mbGlnaHQsIGxpc3QpIHsKPiAgCQlz d2l0Y2ggKGluZmxpZ2h0X2NtZC0+Y3JxLmdlbmVyaWMuY21kKSB7Cj4gIAkJY2FzZSBMT0dJTjoK PiAgCQkJZG1hX3VubWFwX3NpbmdsZShkZXYsIGFkYXB0ZXItPmxvZ2luX2J1Zl90b2tlbiwKPiBA QCAtMzE2NSw4ICszMTY1LDggQEAgc3RhdGljIHZvaWQgaWJtdm5pY19mcmVlX2luZmxpZ2h0KHN0 cnVjdCBpYm12bmljX2FkYXB0ZXIgKmFkYXB0ZXIpCj4gIAkJCWJyZWFrOwo+ICAJCWNhc2UgUkVR VUVTVF9FUlJPUl9JTkZPOgo+ICAJCQlzcGluX2xvY2tfaXJxc2F2ZSgmYWRhcHRlci0+ZXJyb3Jf bGlzdF9sb2NrLCBmbGFnczIpOwo+IC0JCQlsaXN0X2Zvcl9lYWNoX2VudHJ5KGVycm9yX2J1ZmYs ICZhZGFwdGVyLT5lcnJvcnMsCj4gLQkJCQkJICAgIGxpc3QpIHsKPiArCQkJbGlzdF9mb3JfZWFj aF9lbnRyeV9zYWZlKGVycm9yX2J1ZmYsIHRtcDIsCj4gKwkJCQkJCSAmYWRhcHRlci0+ZXJyb3Jz LCBsaXN0KSB7Cj4gIAkJCQlkbWFfdW5tYXBfc2luZ2xlKGRldiwgZXJyb3JfYnVmZi0+ZG1hLAo+ ICAJCQkJCQkgZXJyb3JfYnVmZi0+bGVuLAo+ICAJCQkJCQkgRE1BX0ZST01fREVWSUNFKTsKPgpU aGFua3MhCgpBY2tlZC1ieTogVGhvbWFzIEZhbGNvbiA8dGxmYWxjb25AbGludXgudm5ldC5pYm0u Y29tPgo+Cj4KPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gTGludXhwcGMtZGV2IG1haWxpbmcgbGlzdAo+IExpbnV4cHBjLWRldkBsaXN0cy5vemxh YnMub3JnCj4gaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2xpbnV4cHBjLWRldgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXhwcGMt ZGV2IG1haWxpbmcgbGlzdApMaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xp c3RzLm96bGFicy5vcmcvbGlzdGluZm8vbGludXhwcGMtZGV2