All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suman Anna <s-anna@ti.com>
To: Keerthy <a0393675@ti.com>, "Mohammed, Afzal" <afzal@ti.com>,
	"J, KEERTHY" <j-keerthy@ti.com>,
	"tony@atomide.com" <tony@atomide.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Kristo, Tero" <t-kristo@ti.com>,
	"Gerlach, Dave" <d-gerlach@ti.com>,
	"paul@pwsan.com" <paul@pwsan.com>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>
Subject: Re: [PATCH] ARM: AM43XX: hwmod: Fix RSTST register offset for pruss
Date: Mon, 20 Jun 2016 11:19:07 -0500	[thread overview]
Message-ID: <5768177B.9070306@ti.com> (raw)
In-Reply-To: <5767A81E.1040809@ti.com>

Hi Afzal,

On 06/20/2016 03:23 AM, Keerthy wrote:
> 
> 
> On Monday 20 June 2016 12:35 PM, Mohammed, Afzal wrote:
>> Hi,
>>
>> J, KEERTHY wrote on Monday, June 20, 2016 9:22 AM:
>>
>>> pruss hwmod RSTST register wrongly points to PWRSTCTRL register in
>>> case of
>>> am43xx. Fix the RSTST register offset value.
>>
>>> This can lead to setting of wrong power state values for PER domain.
>>
>> Just curious, does it happen or noticed by going thr' the code ?

It does happen when the pruss module is exercised. We found this when we
tried to do a standby test on suspend, and while it worked on AM33xx,
AM437x failed because of this difference.

regards
Suman

> 
> No i was trying omap4_prminst_deassert_hardreset on AM43XX on my local
> tree and i saw issues and then saw that RSTST register offsets were
> wrongly populated. Hence fixing the same.
> 
>>
>> Regards
>> afzal
>>

  reply	other threads:[~2016-06-20 16:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-20  3:52 [PATCH] ARM: AM43XX: hwmod: Fix RSTST register offset for pruss Keerthy
2016-06-20  3:52 ` Keerthy
2016-06-20  7:05 ` Mohammed, Afzal
2016-06-20  8:23   ` Keerthy
2016-06-20 16:19     ` Suman Anna [this message]
2016-06-21  7:52       ` Mohammed, Afzal
2016-06-21  7:52         ` Mohammed, Afzal
2016-06-21  9:57         ` Keerthy
2016-06-22  9:10           ` Keerthy
2016-06-22  9:59             ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5768177B.9070306@ti.com \
    --to=s-anna@ti.com \
    --cc=a0393675@ti.com \
    --cc=afzal@ti.com \
    --cc=d-gerlach@ti.com \
    --cc=j-keerthy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=paul@pwsan.com \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.