From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF29I-0001x9-CR for qemu-devel@nongnu.org; Mon, 20 Jun 2016 12:34:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bF29D-0005sa-Au for qemu-devel@nongnu.org; Mon, 20 Jun 2016 12:34:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF29D-0005sI-2t for qemu-devel@nongnu.org; Mon, 20 Jun 2016 12:34:03 -0400 References: <1466216924-22172-1-git-send-email-vaibhav@digitalocean.com> From: Eric Blake Message-ID: <57681AF9.10505@redhat.com> Date: Mon, 20 Jun 2016 10:34:01 -0600 MIME-Version: 1.0 In-Reply-To: <1466216924-22172-1-git-send-email-vaibhav@digitalocean.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cH210rf9ru5wXMeRIg5curvN41dB4S1EK" Subject: Re: [Qemu-devel] [PATCH] rbd: reload ceph config for block device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vaibhav Bhembre , qemu-devel@nongnu.org Cc: Josh Durgin , Jeff Cody This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cH210rf9ru5wXMeRIg5curvN41dB4S1EK From: Eric Blake To: Vaibhav Bhembre , qemu-devel@nongnu.org Cc: Josh Durgin , Jeff Cody Message-ID: <57681AF9.10505@redhat.com> Subject: Re: [Qemu-devel] [PATCH] rbd: reload ceph config for block device References: <1466216924-22172-1-git-send-email-vaibhav@digitalocean.com> In-Reply-To: <1466216924-22172-1-git-send-email-vaibhav@digitalocean.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/17/2016 08:28 PM, Vaibhav Bhembre wrote: > This patch adds ability to reload ceph configuration for an attached RB= D > block device. This is necessary for the cases where rebooting a VM and/= or > detaching-reattaching a RBD drive is not an easy option. >=20 > The reload mechanism relies on the bdrv_reopen_* calls to provide a tra= nsactional > +++ b/qapi-schema.json > @@ -4308,3 +4308,16 @@ > # Since: 2.7 > ## > { 'command': 'query-hotpluggable-cpus', 'returns': ['HotpluggableCPU']= } > + > +## > +# @reload-rbd-config > +# > +# Reload the ceph config for a given RBD block device attached to the = VM. > +# > +# @device: Name of the device. > +# > +# Returns: nothing on success. > +# > +# Since: 2.5 You've missed 2.5 by a long shot. This should be 2.7. > +## > +{'command': 'reload-rbd-config', 'data': { 'device': 'str' } } Would 'node' be a better name than 'device'? Isn't this really reloading the state of an arbitrary BDS node, regardless of whether (or even if) there is a BB device using that BDS? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cH210rf9ru5wXMeRIg5curvN41dB4S1EK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXaBr5AAoJEKeha0olJ0Nq7ZoH/jWkQnqBui/spYYIMKiSqVZ3 IDxhHePloxXajr4HBDkqXJPFvHdKm0hbEaE+t6ijaiNw1byDxMe0RcIZjaZQ2bzN 6+zD8Jdan4KavWV5V6mSilWcPpHjNDv3iMILOjjAA8fYwGgYZaV3JMt0bSxuVukT eOV56H7CK9M6JfExksYmjtlkqPNDrnfX5fk3AUdK901wAkICnNFDJdSZ93NbjJl3 jcO0MwOqzCaNVIdNH6V1okszi0feUqHtxI9XobXf72mOcKL1fW0zv0r7g04m0LIE 4wozmpDJu2/ixfthm+VyaTWXHznVuRHR5UJtYESTOkXQMslLfAUKIs6JHJp3eaA= =aYR4 -----END PGP SIGNATURE----- --cH210rf9ru5wXMeRIg5curvN41dB4S1EK--