All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Holger Hoffstätte" <holger@applied-asynchrony.com>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: What happened to the sb writeback list (aka sync efficiency) fix?
Date: Mon, 20 Jun 2016 19:51:20 +0200	[thread overview]
Message-ID: <57682D18.6030005@applied-asynchrony.com> (raw)
In-Reply-To: <20160620164334.GB9474@laptop.bfoster>

On 06/20/16 18:43, Brian Foster wrote:
> On Mon, Jun 20, 2016 at 01:46:38PM +0000, Holger Hoffstätte wrote:
>>
>> Once upon a time there was this fine patch set called
>> "improve sync efficiency with sb inode wb list" [1]
>> by Brian Foster, who fixed up the original version by Josef Bacik.
>>
>> I've been running with this since then and it seems to work flawlessly,
>> yet it doesn't seem that this ever got merged..does anybody know why?
>>
>> Waiman Long has been working on something similar with his per-CPU
>> lists, but those patches naturally collide a bit, so I'm wondering
>> what's what.
>>
>> Fwiw the effect of the wb list on systems with many cached inodes is
>> phenomal; it would be a shame if this went unmerged.
>>
> 
> FWIW, the latest version posted was v7:
> 
> http://thread.gmane.org/gmane.linux.file-systems/104078

Ah yes..that was a comment update so I didn't merge it.

> Thanks for the testing feedback. Unfortunately, I've not really heard
> any feedback on getting this merged. I'm not sure the previous
> version(s) by Josef and Dave got much traction either. :(

The early versions by Josef had a lockdep issue, which your version
apparently fixed. I've not had a single problem with it..but that
admittedly doesn't mean anything. At some point I tried merging it
with the per-CPU list patches (for fun :) but that turned out a bit
too hairy for me.

cheers,
Holger


  reply	other threads:[~2016-06-20 18:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-20 13:46 What happened to the sb writeback list (aka sync efficiency) fix? Holger Hoffstätte
2016-06-20 16:43 ` Brian Foster
2016-06-20 17:51   ` Holger Hoffstätte [this message]
2016-06-21 12:54   ` Jan Kara
2016-06-21 14:03     ` Brian Foster
2016-06-21 14:12       ` Holger Hoffstätte
2016-06-22 11:42         ` Brian Foster
2016-06-22 12:28           ` Holger Hoffstätte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57682D18.6030005@applied-asynchrony.com \
    --to=holger@applied-asynchrony.com \
    --cc=bfoster@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.