From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755800AbcFTVOf (ORCPT ); Mon, 20 Jun 2016 17:14:35 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35474 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753068AbcFTVOW (ORCPT ); Mon, 20 Jun 2016 17:14:22 -0400 Reply-To: minyard@acm.org Subject: Re: [PATCH] ipmi: set si_trydefaults=0 for ARM64 References: <1466447175-14263-1-git-send-email-tcamuso@redhat.com> To: Tony Camuso , openipmi-developer@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org From: Corey Minyard Message-ID: <576858C5.2080000@acm.org> Date: Mon, 20 Jun 2016 15:57:41 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1466447175-14263-1-git-send-email-tcamuso@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/20/2016 01:26 PM, Tony Camuso wrote: > Port I/O space does not exist in ARM64 and is not mapped. Attempts to > access it on ARM systems cause stack traces and worse. At this point, I think it is best to just completely pull out all concept of "default addresses" in the IPMI driver. The defaults were disabled by default in 3.16, this is as good an impetus as any to just get rid of them. If you want, you can do a patch, or I can pull them out if you would prefer that. Thanks, -corey > Signed-off-by: Tony Camuso > --- > drivers/char/ipmi/ipmi_si_intf.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c > index 615abbf..85dcc86 100644 > --- a/drivers/char/ipmi/ipmi_si_intf.c > +++ b/drivers/char/ipmi/ipmi_si_intf.c > @@ -3841,6 +3841,11 @@ static int init_ipmi_si(void) > spmi_find_bmc(); > #endif > > +#ifdef CONFIG_ARM64 > + /* Don't touch port io space */ > + si_trydefaults = 0; > +#endif > + > #ifdef CONFIG_PARISC > register_parisc_driver(&ipmi_parisc_driver); > parisc_registered = true;