From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Simon_K=c3=a5gstr=c3=b6m?= <simon.kagstrom@netinsight.net>
Subject: Re: [PATCH / RFC] sched: Correct subport calcuation
Date: Tue, 21 Jun 2016 08:40:58 +0200
Message-ID: <5768E17A.4060404@netinsight.net>
References: <20160610082913.4878ab77@miho>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
To: cristian.dumitrescu@intel.com, stephen@networkplumber.org, dev@dpdk.org,
 thomas.monjalon@6wind.com
Return-path: <dev-bounces@dpdk.org>
Received: from ernst.netinsight.se (ernst.netinsight.se [194.16.221.21])
 by dpdk.org (Postfix) with SMTP id C47C76CCC
 for <dev@dpdk.org>; Tue, 21 Jun 2016 08:41:03 +0200 (CEST)
In-Reply-To: <20160610082913.4878ab77@miho>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi again!

Any news about this patch? I'm off for parental leave starting next week
(until january), so any comments (or simply dropping it!) would be good
to have before that :-)

// Simon

On 2016-06-10 08:29, Simon Kagstrom wrote:
> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> ---
> I'm a total newbie to the rte_sched design and implementation, so I've
> added the RFC.
> 
> We get crashes (at other places in the scheduler) without this code.
> 
>  lib/librte_sched/rte_sched.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
> index 1609ea8..b46ecfb 100644
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> @@ -1869,7 +1869,7 @@ grinder_next_pipe(struct rte_sched_port *port, uint32_t pos)
>  
>  	/* Install new pipe in the grinder */
>  	grinder->pindex = pipe_qindex >> 4;
> -	grinder->subport = port->subport + (grinder->pindex / port->n_pipes_per_subport);
> +	grinder->subport = port->subport + (grinder->pindex / port->n_subports_per_port);
>  	grinder->pipe = port->pipe + grinder->pindex;
>  	grinder->pipe_params = NULL; /* to be set after the pipe structure is prefetched */
>  	grinder->productive = 0;
>