From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH] leds: Add no-op gpio_led_register_device when LED subsystem is disabled Date: Tue, 21 Jun 2016 09:09:09 +0200 Message-ID: <5768E815.5080706@samsung.com> References: <20160613200211.14790-1-afd@ti.com> <20160613200211.14790-13-afd@ti.com> <5760FA52.7010806@samsung.com> <57647DBD.2010406@ti.com> <57679E38.3080901@samsung.com> <57686A94.2010704@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <57686A94.2010704@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: "Andrew F. Davis" Cc: Ulf Hansson , Wolfram Sang , Linus Walleij , Sebastian Reichel , linux-i2c@vger.kernel.org, Ingo Molnar , Aloisio Almeida Jr , lguest@lists.ozlabs.org, Samuel Ortiz , Russell King , linux-leds@vger.kernel.org, linux-mmc@vger.kernel.org, linux-media@vger.kernel.org, linux-pwm@vger.kernel.org, Mauro Carvalho Chehab , Rusty Russell , linux-gpio@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Lauro Ramos Venancio , Miguel Ojeda Sandonis , Richard Purdie , linuxppc-dev@lists.ozlabs.org List-Id: linux-gpio@vger.kernel.org SGkgQW5kcmV3LAoKVGhpcyBwYXRjaCBkb2Vzbid0IGFwcGx5LCBwbGVhc2UgcmViYXNlIG9udG8g cmVjZW50IExFRCB0cmVlLgoKT24gMDYvMjEvMjAxNiAxMjoxMyBBTSwgQW5kcmV3IEYuIERhdmlz IHdyb3RlOgo+IFNvbWUgc3lzdGVtcyB1c2UgJ2dwaW9fbGVkX3JlZ2lzdGVyX2RldmljZScgdG8g bWFrZSBhbiBpbi1tZW1vcnkgY29weSBvZgo+IHRoZWlyIExFRCBkZXZpY2UgdGFibGUgc28gdGhl IG9yaWdpbmFsIGNhbiBiZSByZW1vdmVkIGFzIC5pbml0LnJvZGF0YS4KPiBXaGVuIHRoZSBMRUQg c3Vic3lzdGVtIGlzIG5vdCBlbmFibGVkIHNvdXJjZSBpbiB0aGUgbGVkIGRpcmVjdG9yeSBpcyBu b3QKPiBidWlsdCBhbmQgc28gdGhpcyBmdW5jdGlvbiBtYXkgYmUgdW5kZWZpbmVkLiBGaXggdGhp cyBoZXJlLgo+Cj4gU2lnbmVkLW9mZi1ieTogQW5kcmV3IEYuIERhdmlzIDxhZmRAdGkuY29tPgo+ IC0tLQo+ICAgaW5jbHVkZS9saW51eC9sZWRzLmggfCA4ICsrKysrKysrCj4gICAxIGZpbGUgY2hh bmdlZCwgOCBpbnNlcnRpb25zKCspCj4KPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9sZWRz LmggYi9pbmNsdWRlL2xpbnV4L2xlZHMuaAo+IGluZGV4IGQyYjEzMDYuLmE0YTNkYTYgMTAwNjQ0 Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9sZWRzLmgKPiArKysgYi9pbmNsdWRlL2xpbnV4L2xlZHMu aAo+IEBAIC0zODYsOCArMzg2LDE2IEBAIHN0cnVjdCBncGlvX2xlZF9wbGF0Zm9ybV9kYXRhIHsK PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcg KmRlbGF5X29mZik7CgpDdXJyZW50bHkgdGhlcmUgaXMgc29tZSBzdHVmZiBoZXJlLCBhbmQgaW4g ZmFjdCBpdCBoYXMgYmVlbiBmb3IKYSBsb25nIHRpbWUuCgpQYXRjaCAiW1BBVENIIDEyLzEyXSBs ZWRzOiBPbmx5IGRlc2NlbmQgaW50byBsZWRzIGRpcmVjdG9yeSB3aGVuCkNPTkZJR19ORVdfTEVE UyBpcyBzZXQiIGFsc28gZG9lc24ndCBhcHBseS4KV2hhdCByZXBvc2l0b3J5IGFyZSB5b3UgdXNp bmc/Cgo+ICAgfTsKPgo+ICsjaWZkZWYgQ09ORklHX05FV19MRURTCj4gICBzdHJ1Y3QgcGxhdGZv cm1fZGV2aWNlICpncGlvX2xlZF9yZWdpc3Rlcl9kZXZpY2UoCj4gICAgICAgICAgICAgICAgICBp bnQgaWQsIGNvbnN0IHN0cnVjdCBncGlvX2xlZF9wbGF0Zm9ybV9kYXRhICpwZGF0YSk7Cj4gKyNl bHNlCj4gK3N0YXRpYyBpbmxpbmUgc3RydWN0IHBsYXRmb3JtX2RldmljZSAqZ3Bpb19sZWRfcmVn aXN0ZXJfZGV2aWNlKAo+ICsgICAgICAgICAgICAgICBpbnQgaWQsIGNvbnN0IHN0cnVjdCBncGlv X2xlZF9wbGF0Zm9ybV9kYXRhICpwZGF0YSkKPiArewo+ICsgICAgICAgcmV0dXJuIDA7Cj4gK30K PiArI2VuZGlmCj4KPiAgIGVudW0gY3B1X2xlZF9ldmVudCB7Cj4gICAgICAgICAgQ1BVX0xFRF9J RExFX1NUQVJULCAgICAgLyogQ1BVIGVudGVycyBpZGxlICovCj4KCgotLSAKQmVzdCByZWdhcmRz LApKYWNlayBBbmFzemV3c2tpCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkxpbnV4cHBjLWRldiBtYWlsaW5nIGxpc3QKTGludXhwcGMtZGV2QGxpc3RzLm96 bGFicy5vcmcKaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2xpbnV4cHBjLWRldg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:16902 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024AbcFUHLp (ORCPT ); Tue, 21 Jun 2016 03:11:45 -0400 Message-id: <5768E815.5080706@samsung.com> (sfid-20160621_091241_198022_876EF796) Date: Tue, 21 Jun 2016 09:09:09 +0200 From: Jacek Anaszewski MIME-version: 1.0 To: "Andrew F. Davis" Cc: Russell King , Miguel Ojeda Sandonis , Linus Walleij , Sebastian Reichel , Wolfram Sang , Richard Purdie , Rusty Russell , Benjamin Herrenschmidt , Mauro Carvalho Chehab , Ulf Hansson , Lauro Ramos Venancio , Aloisio Almeida Jr , Samuel Ortiz , Ingo Molnar , linux-pwm@vger.kernel.org, lguest@lists.ozlabs.org, linux-wireless@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH] leds: Add no-op gpio_led_register_device when LED subsystem is disabled References: <20160613200211.14790-1-afd@ti.com> <20160613200211.14790-13-afd@ti.com> <5760FA52.7010806@samsung.com> <57647DBD.2010406@ti.com> <57679E38.3080901@samsung.com> <57686A94.2010704@ti.com> In-reply-to: <57686A94.2010704@ti.com> Content-type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Andrew, This patch doesn't apply, please rebase onto recent LED tree. On 06/21/2016 12:13 AM, Andrew F. Davis wrote: > Some systems use 'gpio_led_register_device' to make an in-memory copy of > their LED device table so the original can be removed as .init.rodata. > When the LED subsystem is not enabled source in the led directory is not > built and so this function may be undefined. Fix this here. > > Signed-off-by: Andrew F. Davis > --- > include/linux/leds.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/leds.h b/include/linux/leds.h > index d2b1306..a4a3da6 100644 > --- a/include/linux/leds.h > +++ b/include/linux/leds.h > @@ -386,8 +386,16 @@ struct gpio_led_platform_data { > unsigned long *delay_off); Currently there is some stuff here, and in fact it has been for a long time. Patch "[PATCH 12/12] leds: Only descend into leds directory when CONFIG_NEW_LEDS is set" also doesn't apply. What repository are you using? > }; > > +#ifdef CONFIG_NEW_LEDS > struct platform_device *gpio_led_register_device( > int id, const struct gpio_led_platform_data *pdata); > +#else > +static inline struct platform_device *gpio_led_register_device( > + int id, const struct gpio_led_platform_data *pdata) > +{ > + return 0; > +} > +#endif > > enum cpu_led_event { > CPU_LED_IDLE_START, /* CPU enters idle */ > -- Best regards, Jacek Anaszewski