From: Florian Vaussard <florian.vaussard@heig-vd.ch>
To: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: Florian Vaussard <florian.vaussard@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>, <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 1/3] iio: potentiometer: mcp4531: Add support for MCP454x, MCP456x, MCP464x and MCP466x
Date: Tue, 21 Jun 2016 09:11:16 +0200 [thread overview]
Message-ID: <5768E894.7050309@heig-vd.ch> (raw)
In-Reply-To: <alpine.DEB.2.02.1606210859150.20893@pmeerw.net>
Hello,
On 06/21/2016 09:04 AM, Peter Meerwald-Stadler wrote:
>
>> @@ -49,8 +49,10 @@ config MCP4531
>> depends on I2C
>> help
>> Say yes here to build support for the Microchip
>> - MCP4531, MCP4532, MCP4551, MCP4552,
>> - MCP4631, MCP4632, MCP4651, MCP4652
>> + MCP4531, MCP4532, MCP4541, MCP4542,
>> + MCP4551, MCP4552, MCP4561, MCP4562,
>> + MCP4631, MCP4632, MCP4641, MCP4642,
>> + MCP4651, MCP4652, MCP4661, MCP4662
>> digital potentiomenter chips.
>
> unrelated typo: potentiometer
> could you please fix it up as a separate patch in you series?
>
Sure, I will do this patch in v2.
> some whitespace around /*sentinel*/ in patch 3/3 would be nice, looks good
> otherwise
I will wait for some more feedback and fix in v2.
Thanks for your review,
Florian
next prev parent reply other threads:[~2016-06-21 7:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 6:55 [PATCH 0/3] iio: potentiometer: mcp4531: New parts and device tree Florian Vaussard
2016-06-21 6:55 ` Florian Vaussard
2016-06-21 6:55 ` [PATCH 1/3] iio: potentiometer: mcp4531: Add support for MCP454x, MCP456x, MCP464x and MCP466x Florian Vaussard
2016-06-21 6:55 ` Florian Vaussard
2016-06-21 7:04 ` Peter Meerwald-Stadler
2016-06-21 7:11 ` Florian Vaussard [this message]
2016-06-21 7:28 ` Peter Rosin
2016-06-21 7:28 ` Peter Rosin
2016-06-21 6:55 ` [PATCH 2/3] iio: potentiometer: mcp4531: Add device tree binding documentation Florian Vaussard
2016-06-21 7:38 ` Peter Rosin
2016-06-21 7:38 ` Peter Rosin
2016-06-21 7:49 ` Florian Vaussard
2016-06-21 7:49 ` Florian Vaussard
2016-06-21 21:37 ` Rob Herring
2016-06-21 21:37 ` Rob Herring
2016-06-21 21:43 ` Rob Herring
2016-06-21 21:43 ` Rob Herring
2016-06-22 6:19 ` Florian Vaussard
2016-06-22 6:19 ` Florian Vaussard
2016-06-21 6:55 ` [PATCH 3/3] iio: potentiometer: mcp4531: Add device tree binding Florian Vaussard
2016-06-21 7:34 ` kbuild test robot
2016-06-21 7:34 ` kbuild test robot
2016-06-21 7:51 ` Peter Rosin
2016-06-21 7:51 ` Peter Rosin
2016-06-22 6:22 ` Florian Vaussard
2016-06-22 6:22 ` Florian Vaussard
2016-06-22 7:06 ` Peter Rosin
2016-06-22 7:06 ` Peter Rosin
2016-06-23 8:50 ` Florian Vaussard
2016-06-23 8:50 ` Florian Vaussard
2016-06-26 14:53 ` Jonathan Cameron
2016-06-26 14:53 ` Jonathan Cameron
2016-06-26 14:53 ` [PATCH 0/3] iio: potentiometer: mcp4531: New parts and device tree Jonathan Cameron
2016-06-26 14:53 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5768E894.7050309@heig-vd.ch \
--to=florian.vaussard@heig-vd.ch \
--cc=florian.vaussard@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.