From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFHgf-0003XA-5T for qemu-devel@nongnu.org; Tue, 21 Jun 2016 05:09:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFHgZ-0005zi-W6 for qemu-devel@nongnu.org; Tue, 21 Jun 2016 05:09:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFHgZ-0005zU-OA for qemu-devel@nongnu.org; Tue, 21 Jun 2016 05:09:31 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5AFA67F09A for ; Tue, 21 Jun 2016 09:09:31 +0000 (UTC) References: <1466437983-27133-1-git-send-email-ehabkost@redhat.com> <1466437983-27133-10-git-send-email-ehabkost@redhat.com> From: Marcel Apfelbaum Message-ID: <57690448.4020706@redhat.com> Date: Tue, 21 Jun 2016 12:09:28 +0300 MIME-Version: 1.0 In-Reply-To: <1466437983-27133-10-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 09/10] qdev: Remove qdev_prop_register_global_list() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org, Markus Armbruster Cc: Paolo Bonzini , Igor Mammedov On 06/20/2016 06:53 PM, Eduardo Habkost wrote: > The function is not used by any QEMU code, except for the > test-qdev-global-props unit test. > > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > * (New patch in series) > --- > hw/core/qdev-properties.c | 9 --------- > include/hw/qdev-properties.h | 1 - > tests/test-qdev-global-props.c | 12 ++++++------ > 3 files changed, 6 insertions(+), 16 deletions(-) > > diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c > index 733cc45..cf1d47f 100644 > --- a/hw/core/qdev-properties.c > +++ b/hw/core/qdev-properties.c > @@ -1027,15 +1027,6 @@ void qdev_prop_register_global(GlobalProperty *prop) > global_props = g_list_append(global_props, prop); > } > > -void qdev_prop_register_global_list(GlobalProperty *props) > -{ > - int i; > - > - for (i = 0; props[i].driver != NULL; i++) { > - qdev_prop_register_global(props+i); > - } > -} > - > static void qdev_prop_set_globals_for_type(DeviceState *dev, > const char *typename) > { > diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h > index 3bd5ea9..3d25c00 100644 > --- a/include/hw/qdev-properties.h > +++ b/include/hw/qdev-properties.h > @@ -190,7 +190,6 @@ void qdev_prop_set_enum(DeviceState *dev, const char *name, int value); > void qdev_prop_set_ptr(DeviceState *dev, const char *name, void *value); > > void qdev_prop_register_global(GlobalProperty *prop); > -void qdev_prop_register_global_list(GlobalProperty *props); > void qdev_prop_set_globals(DeviceState *dev); > void error_set_from_qdev_prop_error(Error **errp, int ret, DeviceState *dev, > Property *prop, const char *value); > diff --git a/tests/test-qdev-global-props.c b/tests/test-qdev-global-props.c > index 37394fa..29c704f 100644 > --- a/tests/test-qdev-global-props.c > +++ b/tests/test-qdev-global-props.c > @@ -78,12 +78,9 @@ static void test_static_prop(void) > static void test_static_globalprop(void) > { > MyType *mt; > - static GlobalProperty props[] = { > - { TYPE_STATIC_PROPS, "prop1", "200" }, > - {} > - }; > + static GlobalProperty prop = { TYPE_STATIC_PROPS, "prop1", "200" }; > > - qdev_prop_register_global_list(props); > + qdev_prop_register_global(&prop); > > mt = STATIC_TYPE(object_new(TYPE_STATIC_PROPS)); > qdev_init_nofail(DEVICE(mt)); > @@ -182,6 +179,7 @@ static const TypeInfo nondevice_type = { > static void test_dynamic_globalprop(void) > { > MyType *mt; > + int i; > static GlobalProperty props[] = { > { TYPE_DYNAMIC_PROPS, "prop1", "101", }, > { TYPE_DYNAMIC_PROPS, "prop2", "102", }, > @@ -190,7 +188,9 @@ static void test_dynamic_globalprop(void) > {} > }; > > - qdev_prop_register_global_list(props); > + for (i = 0; props[i].driver; i++) { > + qdev_prop_register_global(props + i); > + } > > mt = DYNAMIC_TYPE(object_new(TYPE_DYNAMIC_PROPS)); > qdev_init_nofail(DEVICE(mt)); > Reviewed-by: Marcel Apfelbaum Thanks, Marcel