From mboxrd@z Thu Jan 1 00:00:00 1970 From: mmarek@suse.com (Michal Marek) Date: Tue, 21 Jun 2016 11:43:46 +0200 Subject: [Cocci] [PATCH v2 1/3] coccinelle: also catch kzfree() issues In-Reply-To: References: <5767EE79.5090402@suse.com> Message-ID: <57690C52.7080207@suse.com> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr Dne 20.6.2016 v 22:21 Julia Lawall napsal(a): > > > On Mon, 20 Jun 2016, Michal Marek wrote: > >> On 2016-05-23 17:18, Julia Lawall wrote: >>> >>> >>> On Mon, 23 May 2016, Yann Droneaud wrote: >>> >>>> Since commit 3ef0e5ba4673 ('slab: introduce kzfree()'), >>>> kfree() is no more the only function to be considered: >>>> kzfree() should be recognized too. >>>> >>>> In particular, kzfree() must not be called on memory >>>> allocated through devm_*() functions. >>>> >>>> Cc: Johannes Weiner >>>> Signed-off-by: Yann Droneaud >>> >>> Acked-by: Julia Lawall >> >> Hi Julia, >> >> does your ACK apply to the other two patches as well? > > Sorry, I seem to have missed the other two. I have reviewed them now, and > the ack applies to all three. Thanks for checking on it. Np. Applied to kbuild.git#misc now. Michal From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751998AbcFUKDu (ORCPT ); Tue, 21 Jun 2016 06:03:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:33421 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751980AbcFUKDp (ORCPT ); Tue, 21 Jun 2016 06:03:45 -0400 Subject: Re: [PATCH v2 1/3] coccinelle: also catch kzfree() issues To: Julia Lawall References: <5767EE79.5090402@suse.com> Cc: Yann Droneaud , Gilles Muller , Nicolas Palix , Tejun Heo , Greg Kroah-Hartman , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, Johannes Weiner From: Michal Marek Message-ID: <57690C52.7080207@suse.com> Date: Tue, 21 Jun 2016 11:43:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne 20.6.2016 v 22:21 Julia Lawall napsal(a): > > > On Mon, 20 Jun 2016, Michal Marek wrote: > >> On 2016-05-23 17:18, Julia Lawall wrote: >>> >>> >>> On Mon, 23 May 2016, Yann Droneaud wrote: >>> >>>> Since commit 3ef0e5ba4673 ('slab: introduce kzfree()'), >>>> kfree() is no more the only function to be considered: >>>> kzfree() should be recognized too. >>>> >>>> In particular, kzfree() must not be called on memory >>>> allocated through devm_*() functions. >>>> >>>> Cc: Johannes Weiner >>>> Signed-off-by: Yann Droneaud >>> >>> Acked-by: Julia Lawall >> >> Hi Julia, >> >> does your ACK apply to the other two patches as well? > > Sorry, I seem to have missed the other two. I have reviewed them now, and > the ack applies to all three. Thanks for checking on it. Np. Applied to kbuild.git#misc now. Michal