From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFM7B-0007Uc-8Y for qemu-devel@nongnu.org; Tue, 21 Jun 2016 09:53:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFM77-0001mO-56 for qemu-devel@nongnu.org; Tue, 21 Jun 2016 09:53:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37135) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFM76-0001m6-TN for qemu-devel@nongnu.org; Tue, 21 Jun 2016 09:53:13 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6D8BEC05B1ED for ; Tue, 21 Jun 2016 13:53:12 +0000 (UTC) References: <1465526889-8339-1-git-send-email-eblake@redhat.com> <1465526889-8339-2-git-send-email-eblake@redhat.com> <87bn31w1h0.fsf@dusky.pond.sub.org> <5762E4D2.3090700@redhat.com> <87oa70merl.fsf@dusky.pond.sub.org> From: Eric Blake Message-ID: <576946C7.4020303@redhat.com> Date: Tue, 21 Jun 2016 07:53:11 -0600 MIME-Version: 1.0 In-Reply-To: <87oa70merl.fsf@dusky.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Rj3fm0ose8qFenrpEPqXHipxp3rG8Bb8J" Subject: Re: [Qemu-devel] [PATCH 1/4] qobject: Correct JSON lexer grammar comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Rj3fm0ose8qFenrpEPqXHipxp3rG8Bb8J From: Eric Blake To: Markus Armbruster Cc: qemu-devel@nongnu.org, Luiz Capitulino Message-ID: <576946C7.4020303@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/4] qobject: Correct JSON lexer grammar comments References: <1465526889-8339-1-git-send-email-eblake@redhat.com> <1465526889-8339-2-git-send-email-eblake@redhat.com> <87bn31w1h0.fsf@dusky.pond.sub.org> <5762E4D2.3090700@redhat.com> <87oa70merl.fsf@dusky.pond.sub.org> In-Reply-To: <87oa70merl.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/17/2016 01:54 AM, Markus Armbruster wrote: >>> >>> I'll take this one through qapi-next. Thanks! >>> >> >> You may want to squash this in for shorter lines: >> >> >> diff --git a/qobject/json-lexer.c b/qobject/json-lexer.c >> index de16219..b030576 100644 >> --- a/qobject/json-lexer.c >> +++ b/qobject/json-lexer.c >> @@ -21,16 +21,14 @@ >> * Required by JSON (RFC 7159), plus \' extension in "", and extensio= n >> * of parsing case-insensitive non-finite numbers like "NaN" and "-In= f": >> * >> - * \"([^\\\"]|(\\\"|\\'|\\\\|\\/|\\b|\\f|\\n|\\r|\\t| >> - * \\u[0-9a-fA-F][0-9a-fA-F][0-9a-fA-F][0-9a-fA-F]))*\" >> + * \"([^\\\"]|\\[\"'\\/bfnrt]|\\u[0-9a-fA-F]{4})*\" > Doesn't apply as is, but I get what you mean. Applied to qapi-next, > please double-check the result there. Thanks! You lost the comment about 'plus \' extension in ""', which is probably still worth keeping; but otherwise looks okay. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Rj3fm0ose8qFenrpEPqXHipxp3rG8Bb8J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXaUbHAAoJEKeha0olJ0NqSMUIAKyjr8wg3fD20gIUgx+8Ykc0 aMk7vCaj2s6hh/0ecsVb6KggBY//NlyNlIUn/E61avXjt/LgJkm//TmKVY/hJjFe 3rRYEdq2YkGyLqhXJers3cWUlzPy/Q7PxJaE7G8iFZmJzhLqallX3DDbc4XrkH7d 6xLR6x6fYVDFfIzQSODbZ2D/Rfs/G63RNee3VsZXZmJ95vA8ycTkDOQ3lm79V82S r62RvYIlR3dQ0ZdiBMCdqK3U68yTNSvZw+zk2GgIE6fl4E525ELy/kZf2O1lIKIW 1wPBUsYvSuOsMlZyNra6Dj4pv+sxW4cNhPSWPUXZkSmRxbRjKCljeV36H7AiwHI= =yVOR -----END PGP SIGNATURE----- --Rj3fm0ose8qFenrpEPqXHipxp3rG8Bb8J--