From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.iobjects.de ([188.40.134.68]:47522 "EHLO mail02.iobjects.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbcFUOMu (ORCPT ); Tue, 21 Jun 2016 10:12:50 -0400 Subject: Re: What happened to the sb writeback list (aka sync efficiency) fix? To: Brian Foster , Jan Kara References: <20160620164334.GB9474@laptop.bfoster> <20160621125446.GA9266@quack2.suse.cz> <20160621140302.GB62352@bfoster.bfoster> Cc: linux-fsdevel@vger.kernel.org From: =?UTF-8?Q?Holger_Hoffst=c3=a4tte?= Message-ID: <57694B41.1080106@applied-asynchrony.com> Date: Tue, 21 Jun 2016 16:12:17 +0200 MIME-Version: 1.0 In-Reply-To: <20160621140302.GB62352@bfoster.bfoster> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 06/21/16 16:03, Brian Foster wrote: > On Tue, Jun 21, 2016 at 02:54:46PM +0200, Jan Kara wrote: >> On Mon 20-06-16 12:43:34, Brian Foster wrote: >>> On Mon, Jun 20, 2016 at 01:46:38PM +0000, Holger Hoffstätte wrote: >>>> >>>> Once upon a time there was this fine patch set called >>>> "improve sync efficiency with sb inode wb list" [1] >>>> by Brian Foster, who fixed up the original version by Josef Bacik. >>>> >>>> I've been running with this since then and it seems to work flawlessly, >>>> yet it doesn't seem that this ever got merged..does anybody know why? >>>> >>>> Waiman Long has been working on something similar with his per-CPU >>>> lists, but those patches naturally collide a bit, so I'm wondering >>>> what's what. >>>> >>>> Fwiw the effect of the wb list on systems with many cached inodes is >>>> phenomal; it would be a shame if this went unmerged. >>>> >>> >>> FWIW, the latest version posted was v7: >>> >>> http://thread.gmane.org/gmane.linux.file-systems/104078 >>> >>> Thanks for the testing feedback. Unfortunately, I've not really heard >>> any feedback on getting this merged. I'm not sure the previous >>> version(s) by Josef and Dave got much traction either. :( >> >> Actually it would be a pitty to have this dropped. Please rebase & resend >> the patches and send them to AKPM asking him to merge them because Al isn't >> replying... That should make things moving. >> > > Sure, it rebases clean so I can post a v8 after I get a chance to run > some regression tests. > > Holger, > > Care to offer a Tested-by? My pleasure: Tested-by: Holger Hoffstätte I did this on my custom 4.4.x++ frankenkernel, but I don't see why it wouldn't work on mainline. cheers, Holger