From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:43391 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751736AbcFUOZ3 (ORCPT ); Tue, 21 Jun 2016 10:25:29 -0400 Message-ID: <57694CEB.1050200@candelatech.com> (sfid-20160621_162533_374002_C443F94D) Date: Tue, 21 Jun 2016 07:19:23 -0700 From: Ben Greear MIME-Version: 1.0 To: Johannes Berg , linux-wireless@vger.kernel.org Subject: Re: [PATCH-v2 1/2] mac80211: Take bitrates into account when building IEs. References: <1445361858-24976-1-git-send-email-greearb@candelatech.com> <1453807009.2759.23.camel@sipsolutions.net> <56A78E8F.1080505@candelatech.com> <1454576521.2564.6.camel@sipsolutions.net> <56B38FD1.40902@candelatech.com> <1455827536.2084.35.camel@sipsolutions.net> <56C62C4E.7020600@candelatech.com> <1455828330.2084.38.camel@sipsolutions.net> <56C630B7.7020604@candelatech.com> <1455830078.2084.47.camel@sipsolutions.net> <56C63D8B.9020900@candelatech.com> <1456225589.2041.24.camel@sipsolutions.net> <56E1B556.4080004@candelatech.com> <1458051349.2871.19.camel@sipsolutions.net> <56E833FE.1080904@candelatech.com> <1458073224.2871.22.camel@sipsolutions.net> <575B0A58.8070408@candelatech.com> <1466502039.3170.16.camel@sipsolutions.net> In-Reply-To: <1466502039.3170.16.camel@sipsolutions.net> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 06/21/2016 02:40 AM, Johannes Berg wrote: > On Fri, 2016-06-10 at 11:43 -0700, Ben Greear wrote: >> On 03/15/2016 01:20 PM, Johannes Berg wrote: >>> On Tue, 2016-03-15 at 09:10 -0700, Ben Greear wrote: >>>> >>>> The logic I wrote is basically exactly this. It uses the >>>> configured >>>> rates to specify which of the hardware's rates are allowed and >>>> disabled. >>>> >>> >>> I understand that. I just take issue with the fact that we have to >>> sprinkle "magic pixie dust" (in form of the override function >>> calls) >>> everywhere throughout the code. >>> >>> johannes >>> >> >> So, I never could think up a way to make this more acceptable and >> meet my own goals. >> >> Any chance I could get just the netlink enum in place, even if it is >> called something like 'api_placeholder_x'? >> > > No, I don't think I want to do that. > > But if you're not too worried about space consumption, you could pick a > higher number: > > /* add attributes here, update the policy in nl80211.c */ > > NL80211_ATTR_TX_ADVERT_RATEMASK = 300, > > __NL80211_ATTR_AFTER_LAST, > > We currently use about 230 attributes, so that'll give you lots of > breathing room. From a pure hack point of view, maybe re-purposing some already existing attribute that has nothing to do with scanning is the way to go. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com