From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 325A9E009BF; Tue, 21 Jun 2016 07:57:30 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.192.169 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-pf0-f169.google.com (mail-pf0-f169.google.com [209.85.192.169]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id E4FFFE0099B for ; Tue, 21 Jun 2016 07:57:28 -0700 (PDT) Received: by mail-pf0-f169.google.com with SMTP id c2so7469480pfa.2 for ; Tue, 21 Jun 2016 07:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=NKMVEKpeyzAaZekcbEO9SvQLRqQ0gZ9FKBVP+Xx3eiM=; b=svywRJe4itAspenJNbK5VXArx6eIEOa4tItSBFbZEVFaALllv+8CuAelFTPM22Rbmo la728W1w0Hjo6NwP3UvLb1NEWaf7wete4acpqcRcbljnIC5UZAD5/Up198N75KrSgwvz 1kADuP1Arqn47I1WMxaMOoa2sr/0EDeFMdWjQj7r53K1yIhdfSfkVtgFP/+HxTlTxta9 g7TRm++UvgcfVpQj4kFkMMs6MJ4M+t0HBrTd1erJnZLyYavGCtgy73Lo6Y2nhrxdvQg/ HRTLwY34ZjFDn5SQOKubTWY/UyyLICNeEH7erkC109DkO2zvMqbUgDcy05jKyuSdp59R 6MIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=NKMVEKpeyzAaZekcbEO9SvQLRqQ0gZ9FKBVP+Xx3eiM=; b=DAGZWjrQrNlSbgdbNWCDpyzmO9U086qmqpIziEoy4JWhPPO9wBkYzn0jKVBTgELg7D 9RsvtHD+KninqG6Ly+dv7Lip2UR92TdMNUFSxZeEkQfCTRpCBm3pU264hH77jrojD72e gTFWSxtVMjUmS8X11Hrf7rQHVyjaVHZtJpnzfmAg+shBa2Tgee5bhUG2Bo1i5jBJM8v7 G0OXINBH9GvfSuULotqtxd3VZJjsLbtZ77z9plqOAVFhLV//RRYozJ7Egqkxdk0WmbfH A8B34xK0oEZBI1GI1DAlbgtc3KTMoc3JbjTqzeEjAy4sBL1y+q/jVo9zSf0wwI8yBVt3 eZ9A== X-Gm-Message-State: ALyK8tJg1F7E5WktHY6lwR2eet3qEWbgJFp2LgtFUEsZVHxPFk5mJywqZNix8ee/s1woX/UP X-Received: by 10.98.157.76 with SMTP id i73mr28520409pfd.153.1466521048058; Tue, 21 Jun 2016 07:57:28 -0700 (PDT) Received: from [192.168.0.78] (host86-169-85-169.range86-169.btcentralplus.com. [86.169.85.169]) by smtp.googlemail.com with ESMTPSA id 64sm68775437pfj.96.2016.06.21.07.57.21 for (version=TLSv1/SSLv3 cipher=OTHER); Tue, 21 Jun 2016 07:57:25 -0700 (PDT) To: toaster@yoctoproject.org References: <1466424046-13234-1-git-send-email-elliot.smith@intel.com> From: Michael Wood Message-ID: <576955CE.80408@intel.com> Date: Tue, 21 Jun 2016 15:57:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1466424046-13234-1-git-send-email-elliot.smith@intel.com> Subject: Re: [PATCH] toaster: fix typo in arguments for libtoaster.js function X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2016 14:57:30 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Thanks, Submitted up to bitbake-devel and applied to toaster-next Also opened a bug to create some tests for the project dashboard. On 20/06/16 13:00, Elliot Smith wrote: > The function for flattening the targets of a previous build > to a space-separated list references prev and next arguments > which aren't in the function signature. This prevents the "Rebuild" > buttons (in the most-recent build section) from working. > > Fix the typo so that the buttons work again. > > Signed-off-by: Elliot Smith > --- > bitbake/lib/toaster/toastergui/static/js/libtoaster.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bitbake/lib/toaster/toastergui/static/js/libtoaster.js b/bitbake/lib/toaster/toastergui/static/js/libtoaster.js > index eafe70d..a1379e1 100644 > --- a/bitbake/lib/toaster/toastergui/static/js/libtoaster.js > +++ b/bitbake/lib/toaster/toastergui/static/js/libtoaster.js > @@ -94,7 +94,7 @@ var libtoaster = (function () { > > /* Flatten the array of targets into a space spearated list */ > if (targets instanceof Array){ > - targets = targets.reduce(function(prevV, nextV){ > + targets = targets.reduce(function(prev, next){ > return prev + ' ' + next; > }); > }