From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] efivar: new package
Date: Tue, 21 Jun 2016 16:41:22 +0100 [thread overview]
Message-ID: <57696022.2060308@imgtec.com> (raw)
In-Reply-To: <20160612140155.BE24D8041E@busybox.osuosl.org>
Hello Thomas,
On 12/06/16 14:59, Thomas Petazzoni wrote:
[snip]
> diff --git a/package/efivar/Config.in b/package/efivar/Config.in
> new file mode 100644
> index 0000000..c507584
> --- /dev/null
> +++ b/package/efivar/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_EFIVAR
> + bool "efivar"
> + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 # linux/nvme.h
> + # doesn't build with uclibc due to lack of uchar.h
> + # doesn't build with musl due to lack of __bswap_constant_16
> + depends on BR2_TOOLCHAIN_USES_GLIBC
> + select BR2_PACKAGE_POPT
> + help
> + Tools and libraries to manipulate EFI variables
> +
> + https://github.com/rhinstaller/efivar
> +
> +comment "efivar requires an (e)glibc toolchain w/ headers >= 3.12"
> + depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 || \
> + !BR2_TOOLCHAIN_USES_GLIBC
shouldn't be
comment "efivar requires an (e)glibc toolchain w/ headers >= 3.12"
depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 || \
BR2_TOOLCHAIN_USES_GLIBC
...?
The package is only compatible with glibc, so it depends on it. The
comment should depend on it as well.
[snip]
Regards,
Vincent.
next prev parent reply other threads:[~2016-06-21 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-12 13:59 [Buildroot] [git commit] efivar: new package Thomas Petazzoni
2016-06-21 15:41 ` Vicente Olivert Riera [this message]
2016-06-21 15:51 ` Thomas Petazzoni
2016-06-21 16:02 ` Vicente Olivert Riera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57696022.2060308@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.