From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Ismael Luceno <ismael@iodev.co.uk>, linux-wireless@vger.kernel.org
Cc: brcm80211-dev-list@broadcom.com
Subject: Re: [PATCH] brcmfmac: Add USB ID for Cisco Linksys AE1200
Date: Tue, 21 Jun 2016 21:02:27 +0200 [thread overview]
Message-ID: <57698F43.3050303@broadcom.com> (raw)
In-Reply-To: <20160621001841.5383-1-ismael@iodev.co.uk>
On 21-06-16 02:18, Ismael Luceno wrote:
> Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
A bit more description would be nice. I am actually wondering why you
would be adding this. If I am not mistaken the AE1200 can not be handled
by brcmfmac. Otherwise I am interested in a kernel log showing the
device probe sequence with brcmfmac loaded with parameter debug=0x1416.
Regards,
Arend
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 4 ++++
> drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 3 +++
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
> index 98b15a9..455fc69 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
> @@ -1462,11 +1462,15 @@ static int brcmf_usb_reset_resume(struct usb_interface *intf)
> #define BRCMF_USB_DEVICE(dev_id) \
> { USB_DEVICE(BRCM_USB_VENDOR_ID_BROADCOM, dev_id) }
>
> +#define LINKSYS_USB_DEVICE(dev_id) \
> + { USB_DEVICE(BRCM_USB_VENDOR_ID_LINKSYS, dev_id) }
> +
> static struct usb_device_id brcmf_usb_devid_table[] = {
> BRCMF_USB_DEVICE(BRCM_USB_43143_DEVICE_ID),
> BRCMF_USB_DEVICE(BRCM_USB_43236_DEVICE_ID),
> BRCMF_USB_DEVICE(BRCM_USB_43242_DEVICE_ID),
> BRCMF_USB_DEVICE(BRCM_USB_43569_DEVICE_ID),
> + LINKSYS_USB_DEVICE(BRCM_USB_43235_LINKSYS_DEVICE_ID),
> { USB_DEVICE(BRCM_USB_VENDOR_ID_LG, BRCM_USB_43242_LG_DEVICE_ID) },
> /* special entry for device with firmware loaded and running */
> BRCMF_USB_DEVICE(BRCM_USB_BCMFW_DEVICE_ID),
> diff --git a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
> index 699f2c2..6666513 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
> +++ b/drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h
> @@ -22,6 +22,7 @@
>
> #define BRCM_USB_VENDOR_ID_BROADCOM 0x0a5c
> #define BRCM_USB_VENDOR_ID_LG 0x043e
> +#define BRCM_USB_VENDOR_ID_LINKSYS 0x13b1
> #define BRCM_PCIE_VENDOR_ID_BROADCOM PCI_VENDOR_ID_BROADCOM
>
> /* Chipcommon Core Chip IDs */
> @@ -56,6 +57,8 @@
>
> /* USB Device IDs */
> #define BRCM_USB_43143_DEVICE_ID 0xbd1e
> +#define BRCM_USB_43235_LINKSYS_DEVICE_ID \
> + 0x0039
> #define BRCM_USB_43236_DEVICE_ID 0xbd17
> #define BRCM_USB_43242_DEVICE_ID 0xbd1f
> #define BRCM_USB_43242_LG_DEVICE_ID 0x3101
>
next prev parent reply other threads:[~2016-06-21 19:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 0:18 [PATCH] brcmfmac: Add USB ID for Cisco Linksys AE1200 Ismael Luceno
2016-06-21 5:45 ` Rafał Miłecki
2016-06-21 16:58 ` Ismael Luceno
2016-06-21 17:27 ` Rafał Miłecki
2016-06-21 19:02 ` Arend van Spriel [this message]
2016-06-22 18:36 ` Ismael Luceno
2016-06-22 19:07 ` Arend van Spriel
2016-06-22 20:54 ` Ismael Luceno
2016-08-20 15:17 ` Ismael Luceno
2016-08-20 17:10 ` Rafał Miłecki
2016-08-20 19:22 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57698F43.3050303@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=ismael@iodev.co.uk \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.