All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kieran Bingham <kieran@ksquared.org.uk>
To: Omar Sandoval <osandov@osandov.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scripts/gdb: add constants.py to .gitignore
Date: Tue, 21 Jun 2016 23:03:39 +0100	[thread overview]
Message-ID: <5769B9BB.2000806@bingham.xyz> (raw)
In-Reply-To: <20160621213441.GA12969@vader.DHCP.thefacebook.com>

On 21/06/16 22:34, Omar Sandoval wrote:
> $ git status
> On branch master
> Untracked files:
>   (use "git add <file>..." to include in what will be committed)
> 
>         asdf
> 
> nothing added to commit but untracked files present (use "git add" to track)
> ----
> 
> tools/thermal/tmon/.gitignore also uses the leading slash.

Aha yes,

find -name .gitignore -exec grep -Hin '^/' {} \;
./tools/thermal/tmon/.gitignore:1:/tmon
./.gitignore:44:/tags
./.gitignore:45:/TAGS
./.gitignore:46:/linux
./.gitignore:47:/vmlinux
./.gitignore:48:/vmlinux.32
./.gitignore:49:/vmlinux-gdb.py
./.gitignore:50:/vmlinuz
./.gitignore:51:/System.map
./.gitignore:52:/Module.markers
./.gitignore:57:/debian/
./.gitignore:62:/tar-install/

I think we'll call this the exception rather than the norm, and I'd
prefer to match the other 177 .gitignore files in their style.

> 
> If you want to drop the /, I'm okay with it.


Thanks for the testing, and checking.
Patch picked, and '/' silently dropped.

-- 
Regards

Kieran Bingham

  reply	other threads:[~2016-06-21 22:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21 21:11 [PATCH v2] scripts/gdb: add constants.py to .gitignore Omar Sandoval
2016-06-21 21:20 ` Kieran Bingham
2016-06-21 21:34   ` Omar Sandoval
2016-06-21 22:03     ` Kieran Bingham [this message]
2016-06-21 22:05       ` Omar Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5769B9BB.2000806@bingham.xyz \
    --to=kieran@ksquared.org.uk \
    --cc=jan.kiszka@siemens.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=osandov@osandov.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.