From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFTqZ-0002v8-Cy for qemu-devel@nongnu.org; Tue, 21 Jun 2016 18:08:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFTqU-0006fn-T8 for qemu-devel@nongnu.org; Tue, 21 Jun 2016 18:08:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60366) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFTqU-0006fj-LK for qemu-devel@nongnu.org; Tue, 21 Jun 2016 18:08:34 -0400 References: <146651540593.29362.4052083744443981585.stgit@fimbulvetr.bsc.es> <146651541133.29362.6693427750748986464.stgit@fimbulvetr.bsc.es> From: Eric Blake Message-ID: <5769BAE0.1040105@redhat.com> Date: Tue, 21 Jun 2016 16:08:32 -0600 MIME-Version: 1.0 In-Reply-To: <146651541133.29362.6693427750748986464.stgit@fimbulvetr.bsc.es> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rLvPCGjgtlsREMQ0NUEFhJa0kH2NW3pMq" Subject: Re: [Qemu-devel] [PATCH 1/2] trace: [linux-user] Commandline arguments to control tracing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Llu=c3=ads_Vilanova?= , qemu-devel@nongnu.org Cc: Riku Voipio , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rLvPCGjgtlsREMQ0NUEFhJa0kH2NW3pMq From: Eric Blake To: =?UTF-8?Q?Llu=c3=ads_Vilanova?= , qemu-devel@nongnu.org Cc: Riku Voipio , Stefan Hajnoczi Message-ID: <5769BAE0.1040105@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2] trace: [linux-user] Commandline arguments to control tracing References: <146651540593.29362.4052083744443981585.stgit@fimbulvetr.bsc.es> <146651541133.29362.6693427750748986464.stgit@fimbulvetr.bsc.es> In-Reply-To: <146651541133.29362.6693427750748986464.stgit@fimbulvetr.bsc.es> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/21/2016 07:23 AM, Llu=C3=ADs Vilanova wrote: > Signed-off-by: Llu=C3=ADs Vilanova > --- > linux-user/main.c | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) >=20 > + {"trace-enable", "QEMU_TRACE_ENABLE",true, handle_arg_trace_enabl= e, > + "name", "enable tracing of specified event names (pass '?' = to show a list of events)"}, ? is a shell metacharacter, and it requires quoting to be safe against globbing against any single-letter files in the current directory. A better suggestion would be to pass 'help' to show a list of events. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --rLvPCGjgtlsREMQ0NUEFhJa0kH2NW3pMq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXabrgAAoJEKeha0olJ0NqN00IAIBvkU995t3Cx2q7gsiYJ/WM TmzhLrWsme9L16UZaMsJmb+QnBNoAaR5CYv0POmpJFy4DJszPRsbseghFOPDEtS2 OY31mH6qCuGbYS8x0E2/iBNUlRclgHCq3/l2/Ra0Dx0mLj2ge9znyBn+fJP8gPq/ mb7DnTqM4V6NsEgltgyqdG65vS3dQHIuqrlAVUXLs8IWUR60TFbEwgiDH7NUbfzk Sw3vbtIabJfaZrPP05IcrYywiVv4Dk5IFuZ5eOZJKhi5khoF6IXse67pJQ5nTAQi K5eVoM5LtorwMZuSsEEnKtsBSdBWBVZONo4mdBYZVNoS8mWvg66DJ03uE8NpfBE= =8vY1 -----END PGP SIGNATURE----- --rLvPCGjgtlsREMQ0NUEFhJa0kH2NW3pMq--