From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFTrC-0003Ks-Fw for qemu-devel@nongnu.org; Tue, 21 Jun 2016 18:09:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFTr7-0006xH-0Q for qemu-devel@nongnu.org; Tue, 21 Jun 2016 18:09:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFTr6-0006x8-Ow for qemu-devel@nongnu.org; Tue, 21 Jun 2016 18:09:12 -0400 References: <146651540593.29362.4052083744443981585.stgit@fimbulvetr.bsc.es> <146651541668.29362.14633530491352662513.stgit@fimbulvetr.bsc.es> From: Eric Blake Message-ID: <5769BB07.6090103@redhat.com> Date: Tue, 21 Jun 2016 16:09:11 -0600 MIME-Version: 1.0 In-Reply-To: <146651541668.29362.14633530491352662513.stgit@fimbulvetr.bsc.es> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="crAXdMvt04WbcLm0HbKqQvp6qQfM5SgvB" Subject: Re: [Qemu-devel] [PATCH 2/2] trace: [bsd-user] Commandline arguments to control tracing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Llu=c3=ads_Vilanova?= , qemu-devel@nongnu.org Cc: Blue Swirl , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --crAXdMvt04WbcLm0HbKqQvp6qQfM5SgvB From: Eric Blake To: =?UTF-8?Q?Llu=c3=ads_Vilanova?= , qemu-devel@nongnu.org Cc: Blue Swirl , Stefan Hajnoczi Message-ID: <5769BB07.6090103@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] trace: [bsd-user] Commandline arguments to control tracing References: <146651540593.29362.4052083744443981585.stgit@fimbulvetr.bsc.es> <146651541668.29362.14633530491352662513.stgit@fimbulvetr.bsc.es> In-Reply-To: <146651541668.29362.14633530491352662513.stgit@fimbulvetr.bsc.es> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/21/2016 07:23 AM, Llu=C3=ADs Vilanova wrote: > Signed-off-by: Llu=C3=ADs Vilanova > --- > bsd-user/main.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) >=20 > diff --git a/bsd-user/main.c b/bsd-user/main.c > index 9f592be..ce2cc17 100644 > --- a/bsd-user/main.c > +++ b/bsd-user/main.c > @@ -30,6 +30,7 @@ > #include "qemu/timer.h" > #include "qemu/envlist.h" > #include "exec/log.h" > +#include "trace/control.h" > =20 > int singlestep; > unsigned long mmap_min_addr; > @@ -687,6 +688,14 @@ static void usage(void) > "-p pagesize set the host page size to 'pagesize'\n" > "-singlestep always run in singlestep mode\n" > "-strace log system calls\n" > + "-trace-enable name\n" > + " enable tracing of specified event names\= n" > + " (pass '?' to show a list of events)\n" Same complaint as in 1/2. Also, why does this one split into two lines, while that one had long lines? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --crAXdMvt04WbcLm0HbKqQvp6qQfM5SgvB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXabsHAAoJEKeha0olJ0NqxUcH/0qEjdCeGs24k5A519giQ2aO Zw3PXVwzLR/m+jqCtDGNaYw6Zi4ofMzXwi56scJWr5BsjSAR422xGrNj0Qe8ibqt dFB+uGDuJ3EjrZmCrVqLW2TY0DhKk0KsSZ6SwqVDoszVZa+rOHb8vq1PeIZouU4Z VfXdw38PrEJ2R0b+wFpehrDiAjnTrddPXoSI+PVPZnL8/Kpm5Gu0ZCn8FJj/t5hd uhc3lN0iDInWxUmiGLC2jC/igP+PSlnO3HPbcwESE0i3GBr+q2XXLYEh+sxCdXtr l+KPPe4LzTkpiALJsa+uZ9F00eJw0h9j4ottgndSYr+jFsCfdXLZfW7GHfzqjXo= =8Ky/ -----END PGP SIGNATURE----- --crAXdMvt04WbcLm0HbKqQvp6qQfM5SgvB--