From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yisen.zhuang@huawei.com (Yisen Zhuang) Date: Wed, 22 Jun 2016 09:41:43 +0800 Subject: [PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable In-Reply-To: <097b1147-3587-9579-0f94-f42be130773c@cogentembedded.com> References: <1466481399-70080-1-git-send-email-Yisen.Zhuang@huawei.com> <1466481399-70080-17-git-send-email-Yisen.Zhuang@huawei.com> <097b1147-3587-9579-0f94-f42be130773c@cogentembedded.com> Message-ID: <5769ECD7.8080303@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ? 2016/6/21 21:25, Sergei Shtylyov ??: > Hello. > > On 6/21/2016 6:56 AM, Yisen Zhuang wrote: > >> From: Jun He >> >> When hns_nic_poll_rx_skb alloc skb fail, it will break receive cycle and >> read new fbd_num to start new receive cycle. It recomputes cycle num is >> fbd_num minus clean_count, actually this cycle num is too big because >> it drop out receive cycle. It brings about the port unavailable. >> >> So we will goto out when alloc skb fail to fix this bug. >> >> Signed-off-by: Jun He >> Signed-off-by: Ding Tianhong >> Signed-off-by: Yisen Zhuang >> --- >> drivers/net/ethernet/hisilicon/hns/hns_enet.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c >> index f49246d..c0ce37b 100644 >> --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c >> +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c >> @@ -768,10 +768,10 @@ recv: >> clean_count = 0; >> } >> >> - /* poll one pkg*/ >> + /* poll one pkt*/ I will fix it with a new patch. Thanks, Yisen > > How about adding a space before */? > > [...] > > MBR, Sergei > > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752312AbcFVBqV (ORCPT ); Tue, 21 Jun 2016 21:46:21 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:5220 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752261AbcFVBqR (ORCPT ); Tue, 21 Jun 2016 21:46:17 -0400 Subject: Re: [PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable To: Sergei Shtylyov , , , References: <1466481399-70080-1-git-send-email-Yisen.Zhuang@huawei.com> <1466481399-70080-17-git-send-email-Yisen.Zhuang@huawei.com> <097b1147-3587-9579-0f94-f42be130773c@cogentembedded.com> CC: , , , , , , , , , , , , From: Yisen Zhuang Message-ID: <5769ECD7.8080303@huawei.com> Date: Wed, 22 Jun 2016 09:41:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <097b1147-3587-9579-0f94-f42be130773c@cogentembedded.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.74.157.38] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090202.5769ECE6.00ED,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: cd4e495cdb7c79d304b7dbea67a39386 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016/6/21 21:25, Sergei Shtylyov 写道: > Hello. > > On 6/21/2016 6:56 AM, Yisen Zhuang wrote: > >> From: Jun He >> >> When hns_nic_poll_rx_skb alloc skb fail, it will break receive cycle and >> read new fbd_num to start new receive cycle. It recomputes cycle num is >> fbd_num minus clean_count, actually this cycle num is too big because >> it drop out receive cycle. It brings about the port unavailable. >> >> So we will goto out when alloc skb fail to fix this bug. >> >> Signed-off-by: Jun He >> Signed-off-by: Ding Tianhong >> Signed-off-by: Yisen Zhuang >> --- >> drivers/net/ethernet/hisilicon/hns/hns_enet.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c >> index f49246d..c0ce37b 100644 >> --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c >> +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c >> @@ -768,10 +768,10 @@ recv: >> clean_count = 0; >> } >> >> - /* poll one pkg*/ >> + /* poll one pkt*/ I will fix it with a new patch. Thanks, Yisen > > How about adding a space before */? > > [...] > > MBR, Sergei > > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yisen Zhuang Subject: Re: [PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable Date: Wed, 22 Jun 2016 09:41:43 +0800 Message-ID: <5769ECD7.8080303@huawei.com> References: <1466481399-70080-1-git-send-email-Yisen.Zhuang@huawei.com> <1466481399-70080-17-git-send-email-Yisen.Zhuang@huawei.com> <097b1147-3587-9579-0f94-f42be130773c@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: ivecera@redhat.com, andrew@lunn.ch, fengguang.wu@intel.com, liguozhu@huawei.com, arnd@arndb.de, charles.chenxin@huawei.com, linux-kernel@vger.kernel.org, linuxarm@huawei.com, geliangtang@163.com, huangdaode@hisilicon.com, netdev@vger.kernel.org, andriy.shevchenko@linux.intel.com, linux-arm-kernel@lists.infradead.org To: Sergei Shtylyov , , , Return-path: In-Reply-To: <097b1147-3587-9579-0f94-f42be130773c@cogentembedded.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org CgrlnKggMjAxNi82LzIxIDIxOjI1LCBTZXJnZWkgU2h0eWx5b3Yg5YaZ6YGTOgo+IEhlbGxvLgo+ IAo+IE9uIDYvMjEvMjAxNiA2OjU2IEFNLCBZaXNlbiBaaHVhbmcgd3JvdGU6Cj4gCj4+IEZyb206 IEp1biBIZSA8aGphdDIwMDVAaHVhd2VpLmNvbT4KPj4KPj4gV2hlbiBobnNfbmljX3BvbGxfcnhf c2tiIGFsbG9jIHNrYiBmYWlsLCBpdCB3aWxsIGJyZWFrIHJlY2VpdmUgY3ljbGUgYW5kCj4+IHJl YWQgbmV3IGZiZF9udW0gdG8gc3RhcnQgbmV3IHJlY2VpdmUgY3ljbGUuIEl0IHJlY29tcHV0ZXMg Y3ljbGUgbnVtIGlzCj4+IGZiZF9udW0gbWludXMgY2xlYW5fY291bnQsIGFjdHVhbGx5IHRoaXMg Y3ljbGUgbnVtIGlzIHRvbyBiaWcgYmVjYXVzZQo+PiBpdCBkcm9wIG91dCByZWNlaXZlIGN5Y2xl LiBJdCBicmluZ3MgYWJvdXQgdGhlIHBvcnQgdW5hdmFpbGFibGUuCj4+Cj4+IFNvIHdlIHdpbGwg Z290byBvdXQgd2hlbiBhbGxvYyBza2IgZmFpbCB0byBmaXggdGhpcyBidWcuCj4+Cj4+IFNpZ25l ZC1vZmYtYnk6IEp1biBIZSA8aGphdDIwMDVAaHVhd2VpLmNvbT4KPj4gU2lnbmVkLW9mZi1ieTog RGluZyBUaWFuaG9uZyA8ZGluZ3RpYW5ob25nQGh1YXdlaS5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6 IFlpc2VuIFpodWFuZyA8WWlzZW4uWmh1YW5nQGh1YXdlaS5jb20+Cj4+IC0tLQo+PiAgZHJpdmVy cy9uZXQvZXRoZXJuZXQvaGlzaWxpY29uL2hucy9obnNfZW5ldC5jIHwgNSArKystLQo+PiAgMSBm aWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L2hpc2lsaWNvbi9obnMvaG5zX2VuZXQuYyBiL2Ry aXZlcnMvbmV0L2V0aGVybmV0L2hpc2lsaWNvbi9obnMvaG5zX2VuZXQuYwo+PiBpbmRleCBmNDky NDZkLi5jMGNlMzdiIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL25ldC9ldGhlcm5ldC9oaXNpbGlj b24vaG5zL2huc19lbmV0LmMKPj4gKysrIGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvaGlzaWxpY29u L2hucy9obnNfZW5ldC5jCj4+IEBAIC03NjgsMTAgKzc2OCwxMCBAQCByZWN2Ogo+PiAgICAgICAg ICAgICAgY2xlYW5fY291bnQgPSAwOwo+PiAgICAgICAgICB9Cj4+Cj4+IC0gICAgICAgIC8qIHBv bGwgb25lIHBrZyovCj4+ICsgICAgICAgIC8qIHBvbGwgb25lIHBrdCovCgpJIHdpbGwgZml4IGl0 IHdpdGggYSBuZXcgcGF0Y2guCgpUaGFua3MsCgpZaXNlbgoKPiAKPiAgICBIb3cgYWJvdXQgYWRk aW5nIGEgc3BhY2UgYmVmb3JlICovPwo+IAo+IFsuLi5dCj4gCj4gTUJSLCBTZXJnZWkKPiAKPiAK PiAuCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo=