From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v3 0/10] Date: Wed, 22 Jun 2016 10:24:31 +0800 Message-ID: <5769F6DF.4050507@rock-chips.com> References: <1465904718-663-1-git-send-email-ykk@rock-chips.com> <5769453B.5070208@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5769453B.5070208@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Archit Taneja , Mark Yao , Inki Dae , Jingoo Han , Heiko Stuebner Cc: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, daniel.vetter@ffwll.ch, emil.l.velikov@gmail.com, dianders@chromium.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas , Tomasz Figa , =?UTF-8?Q?St=c3=a9phane_Marchesin?= , Thierry Reding , Dan Carpenter List-Id: linux-rockchip.vger.kernel.org QXJjaGl0LAoKT24gMDYvMjEvMjAxNiAwOTo0NiBQTSwgQXJjaGl0IFRhbmVqYSB3cm90ZToKPgo+ Cj4gT24gNi8xNC8yMDE2IDU6MTUgUE0sIFlha2lyIFlhbmcgd3JvdGU6Cj4+IFJLMzM5OSBhbmQg UkszMjg4IHNoYXJlZCB0aGUgc2FtZSBlRFAgSVAgY29udHJvbGxlciwgb25seSBzb21lIGxpZ2h0 Cj4+IGRpZmZlcmVuY2Ugd2l0aCBWT1AgY29uZmlndXJlIGFuZCBHUkYgY29uZmlndXJlLgo+Pgo+ PiBBbHNvIHNhbWUgbWlzYyBmaXggdG8gYW5hbG9naXhfZHAgZHJpdmVyOgo+PiAtIEhvdHBsdWcg aW52YWxpZCB3aGljaCByZXBvcnQgYnkgRGFuIENhcnBlbnRlcgo+PiAtIE1ha2UgcGFuZWwgZGV0 ZWN0IHRvIGFuIG9wdGlvbmFsIGFjdGlvbgo+PiAtIGNvcnJlY3QgdGhlIHJlZ2lzdGVyIGJpdCBk ZWZpbmUgZXJyb3IgaW4gQU5BTE9HSVhfRFBfUExMX1JFR18xCj4+Cj4+Cj4+IENoYW5nZXMgaW4g djM6Cj4+IC0gQ29ycmVjdCB0aGUgbWlzc3BlbGwgb2YgIm1hcmNvcyIgaW4gY29tbWl0IG1lc3Nh Z2UgKERvbWluaWssIAo+PiByZXZpZXdlZCBhdCBHb29nbGUgR2Vycml0KQo+PiBbaHR0cHM6Ly9j aHJvbWl1bS1yZXZpZXcuZ29vZ2xlc291cmNlLmNvbS8jL2MvMzQ2MzEyLzkvL0NPTU1JVF9NU0dA OV0KPj4gLSBBZGQgcmV2aWV3ZWQgZmxhZyBmcm9tIFN0w6lwaGFuZS4KPj4gICAgICBbaHR0cHM6 Ly9jaHJvbWl1bS1yZXZpZXcuZ29vZ2xlc291cmNlLmNvbS8jL2MvMzQ2MzEyLzE2XQo+PiAtIEFk ZCB0ZXN0ZWQgZmxhZyBmcm9tIEphdmllci4KPj4gLSBXcml0ZSBhIGtlcm5lbGRvYy1zdHlsZSBj b21tZW50IGV4cGxhaW5pbmcgdGhlIGNoaXBzIGRhdGEgZmllbGRzIAo+PiAoVG9tYXN6LCByZXZp ZXdlZCBhdCBHb29nbGUgR2Vycml0KQo+PiBbaHR0cHM6Ly9jaHJvbWl1bS1yZXZpZXcuZ29vZ2xl c291cmNlLmNvbS8jL2MvMzQ2MzEzLzEwL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9hbmFsb2dp eF9kcC1yb2NrY2hpcC5jQDM5XQo+PiAtIERyb3AgdGhlICcubGNkY3NlbF9tYXNrJyBudW1iZXIg aW4gY2hpcHMgZGF0YSBmaWVsZCAoVG9tYXN6LCAKPj4gcmV2aWV3ZWQgYXQgR29vZ2xlIEdlcnJp dCkKPj4gW2h0dHBzOi8vY2hyb21pdW0tcmV2aWV3Lmdvb2dsZXNvdXJjZS5jb20vIy9jLzM0NjMx My8xMC9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvYW5hbG9naXhfZHAtcm9ja2NoaXAuY0AzODJd Cj4+IC0gQWRkIGFja2VkIGZsYWcgZnJvbSBNYXJrLgo+PiAtIEFkZCByZXZpZXdlZCBmbGFnIGZy b20gVG9tYXN6Lgo+PiAgICAgIFtodHRwczovL2Nocm9taXVtLXJldmlldy5nb29nbGVzb3VyY2Uu Y29tLyMvYy8zNDYzMTUvMTVdCj4+IC0gQWRkIHRlc3RlZCBmbGFnIGZyb20gSmF2aWVyCj4+IC0g TWFrZSB0aGlzIGhhY2sgY29kZSBtb3JlIGNsZWFyIChUb21hc3osIHJldmlld2VkIGF0IEdvb2ds ZSBHZXJyaXQpCj4+ICAgIHJlZyA9IH5yZWcgJiBSRUZfQ0xLX01BU0s7ICAtLS0+ICByZWcgXj0g UkVGX0NMS19NQVNLOwo+PiBbaHR0cHM6Ly9jaHJvbWl1bS1yZXZpZXcuZ29vZ2xlc291cmNlLmNv bS8jL2MvMzQ2ODUyLzcvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9k cF9yZWcuY0A4MF0KPj4gLSBBZGQgdGVzdGVkIGZsYWcgZnJvbSBKYXZpZXIKPj4gLSBHaXZlIHRo ZSAicmszMzk5LWVkcCIgYSBzZXBhcmF0ZSBsaW5lIGZvciBjbGFyaXR5IGluIGRvY3VtZW50IAo+ PiAoVG9tYXN6LCByZXZpZXdlZCBhdCBHb29nbGUgR2Vycml0KQo+PiBbaHR0cHM6Ly9jaHJvbWl1 bS1yZXZpZXcuZ29vZ2xlc291cmNlLmNvbS8jL2MvMzQ2MzE0LzEwL0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3JvY2tjaGlwL2FuYWxvZ2l4X2RwLXJvY2tjaGlwLnR4 dEA1XQo+PiAtIE1vdmUgJ291dHB1dF90eXBlJyBzZXR0aW5nIGJlZm9yZSB0aGUgcmV0dXJuIHN0 YXRlbWVudCAoVG9tYXN6LCAKPj4gcmV2aWV3ZWQgYXQgR29vZ2xlIEdlcnJpdCkKPj4gW2h0dHBz Oi8vY2hyb21pdW0tcmV2aWV3Lmdvb2dsZXNvdXJjZS5jb20vIy9jLzM0NjMxNC8xMC9kcml2ZXJz L2dwdS9kcm0vcm9ja2NoaXAvYW5hbG9naXhfZHAtcm9ja2NoaXAuY0AxNTRdCj4+IC0gQWRkIHRo ZSBhY2tlZCBmbGFnIGZyb20gTWFyay4KPj4gLSBBZGQgdGhlIGFja2VkIGZsYWcgZnJvbSBNYXJr Lgo+PiAtIEF2b2lkIHRvIGNoYW5nZSBhbnkgaW50ZXJuYWwgZHJpdmVyIHN0YXRlIGluIC5tb2Rl X3ZhbGlkIGludGVyZmFjZS4gCj4+IChUb21hc3osIHJldmlld2VkIGF0IEdvb2dsZSBHZXJyaXQp Cj4+IFtodHRwczovL2Nocm9taXVtLXJldmlldy5nb29nbGVzb3VyY2UuY29tLyMvYy8zNDYzMTgv MTAvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2FuYWxvZ2l4X2RwLXJvY2tjaGlwLmNAMTEzXQo+ PiAtIEhvb2sgdGhlIGNvbm5lY3RvcidzIGNvbG9yX2Zvcm1hdHMgaW4gLmdldF9tb2RlcyBkaXJl Y3RseS4gKFRvbWFzeiwgCj4+IHJldmlld2VkIGF0IEdvb2dsZSBHZXJyaXQpCj4+ICAgICAgW2h0 dHBzOi8vY2hyb21pdW0tcmV2aWV3Lmdvb2dsZXNvdXJjZS5jb20vIy9jLzM0NjMxNy8xNV0KPj4g LSBBZGQgdGhlIGFja2VkIGZsYWcgZnJvbSBNYXJrLgo+PiAtIEFkZCB0aGUgcmV2aWV3ZWQgZmxh ZyBmcm9tIFRvbWFzei4KPj4gICAgICBbaHR0cHM6Ly9jaHJvbWl1bS1yZXZpZXcuZ29vZ2xlc291 cmNlLmNvbS8jL2MvMzQ2ODUzLzEyXQo+PiAtIEFkZCB0aGUgYWNrZWQgZmxhZyBmcm9tIE1hcmsu Cj4+IC0gQWRkIHJldmlld2VkIGZsYWcgZnJvbSBTdMOpcGhhbmUuCj4+ICAgICAgW2h0dHBzOi8v Y2hyb21pdW0tcmV2aWV3Lmdvb2dsZXNvdXJjZS5jb20vIy9jLzM0NjMxOS8xNV0KPj4gLSBBZGQg dGVzdGVkIGZsYWcgZnJvbSBKYXZpZXIKPj4KPj4gQ2hhbmdlcyBpbiB2MjoKPj4gLSBuZXcgcGF0 Y2ggaW4gdjIKPj4gLSByZWJhc2Ugd2l0aCBkcm0tbmV4dCwgZml4IHNvbWUgY29uZmxpY3RzCj4+ IC0gbmV3IHBhdGNoIGluIHYyCj4+Cj4+IFlha2lyIFlhbmcgKDEwKToKPj4gICAgZHJtL2JyaWRn ZTogYW5hbG9naXhfZHA6IHJlbmFtZSBSSzMyODhfRFAgdG8gUk9DS0NISVBfRFAKPj4gICAgZHJt L3JvY2tjaGlwOiBhbmFsb2dpeF9kcDogc3BsaXQgdGhlIGxjZGMgc2VsZWN0IHNldHRpbmcgaW50 byBkZXZpY2UKPj4gICAgICBkYXRhCj4+ICAgIGRybS9icmlkZ2U6IGFuYWxvZ2l4X2RwOiBjb3Jy ZWN0IHRoZSByZWdpc3RlciBiaXQgZGVmaW5lIGVycm9yIGluCj4+ICAgICAgQU5BTE9HSVhfRFBf UExMX1JFR18xCj4+ICAgIGRybS9icmlkZ2U6IGFuYWxvZ2l4X2RwOiBzb21lIHJvY2tjaGlwIGNo aXBzIG5lZWQgdG8gZmxpcCBSRUZfQ0xLIGJpdAo+PiAgICAgIHNldHRpbmcKPj4gICAgZHJtL3Jv Y2tjaGlwOiBhbmFsb2dpeF9kcDogYWRkIHJrMzM5OSBlRFAgc3VwcG9ydAo+PiAgICBkcm0vcm9j a2NoaXA6IGFuYWxvZ2l4X2RwOiBtYWtlIHBhbmVsIGRldGVjdCB0byBhbiBvcHRpb25hbCBhY3Rp b24KPj4gICAgZHJtL2JyaWRnZTogYW5hbG9naXhfZHA6IHBhc3NpbmcgdGhlIGNvbm5lY3RvciBh cyBhbiBhcmd1bWVudCBpbgo+PiAgICAgIC5nZXRfbW9kZXMoKQo+PiAgICBkcm0vcm9ja2NoaXA6 IGFuYWxvZ2l4X2RwOiBjb3JyZWN0IHRoZSBjb25uZWN0b3IgZGlzcGxheSBjb2xvciBmb3JtYXQK Pj4gICAgICBhbmQgYnBjCj4+ICAgIGRybS9yb2NrY2hpcDogYW5hbG9naXhfZHA6IHVwZGF0ZSB0 aGUgY29tbWVudHMgYWJvdXQgd2h5IG5lZWQgdG8KPj4gICAgICBoYXJkY29kZSBWT1Agb3V0cHV0 IG1vZGUKPj4gICAgZHJtL2JyaWRnZTogYW5hbG9naXhfZHA6IGZpeCBubyBkcm0gaHBkIGV2ZW50 IHdoZW4gcGFuZWwgcGx1ZyBpbgo+Cj4gSXMgdGhlIHBsYW4gdG8gdGFrZSBhbGwgdGhlIGJyaWRn ZStyb2NrY2hpcCBzdHVmZiB2aWEgdGhlIHJvY2tjaGlwIHB1bGwKPiByZXF1ZXN0Pwo+CgpZZXAs IG1vc3Qgb2YgdGhvc2UgcGF0Y2ggbmVlZCB0byByZWx5IG9uIG90aGVycywgc28gaXQncyBiZXR0 ZXIgdG8gCmNvbGxlY3QgYWxsIG9mIHRoZW0gaW50byBvbmUgcHVsbCByZXF1ZXN0IDspCgpUaGFu a3MsCi0gWWFraXIKCj4gVGhhbmtzLAo+IEFyY2hpdAo+Cj4+Cj4+ICAgLi4uL2JpbmRpbmdzL2Rp c3BsYXkvYnJpZGdlL2FuYWxvZ2l4X2RwLnR4dCAgICAgICAgfCAgIDEgKwo+PiAgIC4uLi9kaXNw bGF5L3JvY2tjaGlwL2FuYWxvZ2l4X2RwLXJvY2tjaGlwLnR4dCAgICAgIHwgICAzICstCj4+ICAg ZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9jb3JlLmMgfCAgIDYg Ky0KPj4gICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2RwX2NvcmUu aCB8ICAgOCArLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgvYW5hbG9naXhf ZHBfcmVnLmMgIHwgIDEyICstCj4+ICAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9h bmFsb2dpeF9kcF9yZWcuaCAgfCAgIDUgKy0KPj4gICBkcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4 eW5vc19kcC5jICAgICAgICAgICAgICAgICB8ICAgNCArLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9y b2NrY2hpcC9hbmFsb2dpeF9kcC1yb2NrY2hpcC5jICAgIHwgMTU4IAo+PiArKysrKysrKysrKysr Ky0tLS0tLS0KPj4gICBpbmNsdWRlL2RybS9icmlkZ2UvYW5hbG9naXhfZHAuaCAgICAgICAgICAg ICAgICAgICB8ICAgOSArLQo+PiAgIDkgZmlsZXMgY2hhbmdlZCwgMTQxIGluc2VydGlvbnMoKyks IDY1IGRlbGV0aW9ucygtKQo+Pgo+CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752478AbcFVCgU (ORCPT ); Tue, 21 Jun 2016 22:36:20 -0400 Received: from lucky1.263xmail.com ([211.157.147.131]:46253 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751450AbcFVCgP (ORCPT ); Tue, 21 Jun 2016 22:36:15 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-rockchip@lists.infradead.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v3 0/10] To: Archit Taneja , Mark Yao , Inki Dae , Jingoo Han , Heiko Stuebner References: <1465904718-663-1-git-send-email-ykk@rock-chips.com> <5769453B.5070208@codeaurora.org> Cc: Javier Martinez Canillas , =?UTF-8?Q?St=c3=a9phane_Marchesin?= , Tomasz Figa , David Airlie , daniel.vetter@ffwll.ch, Thierry Reding , dianders@chromium.org, Krzysztof Kozlowski , emil.l.velikov@gmail.com, Dan Carpenter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org From: Yakir Yang Message-ID: <5769F6DF.4050507@rock-chips.com> Date: Wed, 22 Jun 2016 10:24:31 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <5769453B.5070208@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Archit, On 06/21/2016 09:46 PM, Archit Taneja wrote: > > > On 6/14/2016 5:15 PM, Yakir Yang wrote: >> RK3399 and RK3288 shared the same eDP IP controller, only some light >> difference with VOP configure and GRF configure. >> >> Also same misc fix to analogix_dp driver: >> - Hotplug invalid which report by Dan Carpenter >> - Make panel detect to an optional action >> - correct the register bit define error in ANALOGIX_DP_PLL_REG_1 >> >> >> Changes in v3: >> - Correct the misspell of "marcos" in commit message (Dominik, >> reviewed at Google Gerrit) >> [https://chromium-review.googlesource.com/#/c/346312/9//COMMIT_MSG@9] >> - Add reviewed flag from Stéphane. >> [https://chromium-review.googlesource.com/#/c/346312/16] >> - Add tested flag from Javier. >> - Write a kerneldoc-style comment explaining the chips data fields >> (Tomasz, reviewed at Google Gerrit) >> [https://chromium-review.googlesource.com/#/c/346313/10/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c@39] >> - Drop the '.lcdcsel_mask' number in chips data field (Tomasz, >> reviewed at Google Gerrit) >> [https://chromium-review.googlesource.com/#/c/346313/10/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c@382] >> - Add acked flag from Mark. >> - Add reviewed flag from Tomasz. >> [https://chromium-review.googlesource.com/#/c/346315/15] >> - Add tested flag from Javier >> - Make this hack code more clear (Tomasz, reviewed at Google Gerrit) >> reg = ~reg & REF_CLK_MASK; ---> reg ^= REF_CLK_MASK; >> [https://chromium-review.googlesource.com/#/c/346852/7/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c@80] >> - Add tested flag from Javier >> - Give the "rk3399-edp" a separate line for clarity in document >> (Tomasz, reviewed at Google Gerrit) >> [https://chromium-review.googlesource.com/#/c/346314/10/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt@5] >> - Move 'output_type' setting before the return statement (Tomasz, >> reviewed at Google Gerrit) >> [https://chromium-review.googlesource.com/#/c/346314/10/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c@154] >> - Add the acked flag from Mark. >> - Add the acked flag from Mark. >> - Avoid to change any internal driver state in .mode_valid interface. >> (Tomasz, reviewed at Google Gerrit) >> [https://chromium-review.googlesource.com/#/c/346318/10/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c@113] >> - Hook the connector's color_formats in .get_modes directly. (Tomasz, >> reviewed at Google Gerrit) >> [https://chromium-review.googlesource.com/#/c/346317/15] >> - Add the acked flag from Mark. >> - Add the reviewed flag from Tomasz. >> [https://chromium-review.googlesource.com/#/c/346853/12] >> - Add the acked flag from Mark. >> - Add reviewed flag from Stéphane. >> [https://chromium-review.googlesource.com/#/c/346319/15] >> - Add tested flag from Javier >> >> Changes in v2: >> - new patch in v2 >> - rebase with drm-next, fix some conflicts >> - new patch in v2 >> >> Yakir Yang (10): >> drm/bridge: analogix_dp: rename RK3288_DP to ROCKCHIP_DP >> drm/rockchip: analogix_dp: split the lcdc select setting into device >> data >> drm/bridge: analogix_dp: correct the register bit define error in >> ANALOGIX_DP_PLL_REG_1 >> drm/bridge: analogix_dp: some rockchip chips need to flip REF_CLK bit >> setting >> drm/rockchip: analogix_dp: add rk3399 eDP support >> drm/rockchip: analogix_dp: make panel detect to an optional action >> drm/bridge: analogix_dp: passing the connector as an argument in >> .get_modes() >> drm/rockchip: analogix_dp: correct the connector display color format >> and bpc >> drm/rockchip: analogix_dp: update the comments about why need to >> hardcode VOP output mode >> drm/bridge: analogix_dp: fix no drm hpd event when panel plug in > > Is the plan to take all the bridge+rockchip stuff via the rockchip pull > request? > Yep, most of those patch need to rely on others, so it's better to collect all of them into one pull request ;) Thanks, - Yakir > Thanks, > Archit > >> >> .../bindings/display/bridge/analogix_dp.txt | 1 + >> .../display/rockchip/analogix_dp-rockchip.txt | 3 +- >> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 6 +- >> drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 8 +- >> drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 12 +- >> drivers/gpu/drm/bridge/analogix/analogix_dp_reg.h | 5 +- >> drivers/gpu/drm/exynos/exynos_dp.c | 4 +- >> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 158 >> ++++++++++++++------- >> include/drm/bridge/analogix_dp.h | 9 +- >> 9 files changed, 141 insertions(+), 65 deletions(-) >> >