From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFg0d-0003f2-6S for qemu-devel@nongnu.org; Wed, 22 Jun 2016 07:07:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFg0X-0000ce-3y for qemu-devel@nongnu.org; Wed, 22 Jun 2016 07:07:50 -0400 Received: from smtp.ispras.ru ([83.149.199.79]:37346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFg0W-0000b2-Sd for qemu-devel@nongnu.org; Wed, 22 Jun 2016 07:07:45 -0400 References: <1466433559-30930-1-git-send-email-pbonzini@redhat.com> <1466433559-30930-2-git-send-email-pbonzini@redhat.com> From: =?UTF-8?B?0JXRhNC40LzQvtCyINCS0LDRgdC40LvQuNC5?= Message-ID: <576A7175.8080403@ispras.ru> Date: Wed, 22 Jun 2016 14:07:33 +0300 MIME-Version: 1.0 In-Reply-To: <1466433559-30930-2-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] ich9: call ich9_lpc_update_pic for disabled pirqs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org 20.06.2016 17:39, Paolo Bonzini wrote: > An asserted pirq can be disabled and the corresponding GSIs > should then go down to 0. However, because of the conditional in > ich9_lpc_update_by_pirq, the legacy 8259 pin could remain stuck to 1. > > Signed-off-by: Paolo Bonzini > --- > hw/isa/lpc_ich9.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c > index 213741b..b116e1b 100644 > --- a/hw/isa/lpc_ich9.c > +++ b/hw/isa/lpc_ich9.c > @@ -234,9 +234,6 @@ static void ich9_lpc_update_by_pirq(ICH9LPCState *lpc, int pirq) > > ich9_lpc_pic_irq(lpc, pirq, &pic_irq, &pic_dis); > assert(pic_irq < ICH9_LPC_PIC_NUM_PINS); > - if (pic_dis) { > - return; > - } > > ich9_lpc_update_pic(lpc, pic_irq); > } > Reviewed-by: Efimov Vasily