From: Olivier Matz <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
Panu Matilainen <pmatilai@redhat.com>
Cc: dev@dpdk.org, cristian.dumitrescu@intel.com, zhuangwj@gmail.com
Subject: Re: [PATCH] port: fix build when KNI support is not enabled
Date: Wed, 22 Jun 2016 13:57:20 +0200 [thread overview]
Message-ID: <576A7D20.4030801@6wind.com> (raw)
In-Reply-To: <293319946.9flpxUKHBY@xps13>
Hi Thomas,
On 06/22/2016 01:49 PM, Thomas Monjalon wrote:
> 2016-06-22 14:34, Panu Matilainen:
>> --- a/lib/librte_port/Makefile
>> +++ b/lib/librte_port/Makefile
>> @@ -82,6 +82,8 @@ DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_mempool
>> DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_ether
>> DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_ip_frag
>> DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_sched
>> +ifeq ($(CONFIG_RTE_LIBRTE_KNI),y)
>> DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_kni
>> +endif
>
> I do not remember why $(CONFIG_RTE_LIBRTE_PORT) is needed in its Makefile.
> I think we can do
> DEPDIRS-$(CONFIG_RTE_LIBRTE_KNI) += lib/librte_kni
> and set DEPDIRS-y everywhere else.
>
It's probably not much used, but the build framework allows to do
the following to build only one directory:
make lib/librte_port_sub
This directly jumps to the librte_port Makefile, bypassing parent
directories. I think that's why the config check is duplicated in the
Makefile.
Olivier
next prev parent reply other threads:[~2016-06-22 11:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 11:34 [PATCH] port: fix build when KNI support is not enabled Panu Matilainen
2016-06-22 11:49 ` Thomas Monjalon
2016-06-22 11:57 ` Olivier Matz [this message]
2016-06-22 12:20 ` Thomas Monjalon
2016-06-22 15:32 ` Olivier Matz
2016-06-23 8:53 ` Bruce Richardson
2016-06-23 8:59 ` Olivier Matz
2016-06-23 17:19 ` Dumitrescu, Cristian
2016-06-27 10:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576A7D20.4030801@6wind.com \
--to=olivier.matz@6wind.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
--cc=thomas.monjalon@6wind.com \
--cc=zhuangwj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.