Re: [PATCH 3/8] arm/gic-v3: Parse per-cpu redistributor entry in GICC subtable

[Julien Grall <julien.grall@arm.com>]

Hello Shanker,

On 21/06/16 14:52, Shanker Donthineni wrote:
> On 06/21/2016 05:16 AM, Julien Grall wrote:
>> Hello Shanker,
>>
>> On 19/06/16 00:45, Shanker Donthineni wrote:
>>> The redistributor address can be specified either as part of GICC or
>>> GICR subtable depending on the power domain. The current driver
>>> doesn't support parsing redistributor entry that is defined in GICC
>>> subtable. The GIC CPU subtable entry holds the associated Redistributor
>>> base address if it is not on always-on power domain.
>>>
>>> This patch adds necessary code to handle both types of Redistributors
>>> base addresses.
>>>
>>> Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
>>> ---
>>>   xen/arch/arm/gic-v3.c             | 97
>> ++++++++++++++++++++++++++++++++-------
>>>   xen/include/asm-arm/gic.h         |  2 +
>>>   xen/include/asm-arm/gic_v3_defs.h |  1 +
>>>   3 files changed, 83 insertions(+), 17 deletions(-)
>>>
>>> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
>>> index af12ebc..42cf848 100644
>>> --- a/xen/arch/arm/gic-v3.c
>>> +++ b/xen/arch/arm/gic-v3.c
>>> @@ -659,6 +659,10 @@ static int __init gicv3_populate_rdist(void)
>>>                           smp_processor_id(), i, ptr);
>>>                   return 0;
>>>               }
>>> +
>>> +            if ( gicv3.rdist_regions[i].single_rdist )
>>> +                break;
>>> +
>>>               if ( gicv3.rdist_stride )
>>>                   ptr += gicv3.rdist_stride;
>>>               else
>>> @@ -1282,6 +1286,11 @@ static int gicv3_iomem_deny_access(const struct
>> domain *d)
>>>   }
>>>
>>>   #ifdef CONFIG_ACPI
>>> +static bool gic_dist_supports_dvis(void)
>>
>> static inline and please use bool_t here.
>>
> Still learning XEN coding style, I'll fix it.

It looks like Xen is moving towards bool (see [1]). So you can keep bool 
here.

Regards,

[1] 
http://lists.xenproject.org/archives/html/xen-devel/2016-06/msg02807.html

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel