From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan-Marek Glogowski Subject: Re: Brightness and "touchpad dis-/enable" keys not working for Fujitsu e7x6 Date: Wed, 22 Jun 2016 15:22:03 +0200 Message-ID: <576A90FB.9090506@fbihome.de> References: <575FC4E0.7080501@fbihome.de> <20160616234630.GB4764@marvin.atrad.com.au> <5763C0DF.3030302@fbihome.de> <20160621081229.GE19735@marvin.atrad.com.au> <20160622073213.GD3056@eudyptula.hq.kempniu.pl> <576A6604.8010907@fbihome.de> <20160622105333.GD25599@marvin.atrad.com.au> <576A7519.9040703@fbihome.de> <20160622123941.GB2466@eudyptula.hq.kempniu.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from ironchief.h-da.de ([141.100.10.235]:5780 "EHLO ironchief.h-da.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957AbcFVNWH (ORCPT ); Wed, 22 Jun 2016 09:22:07 -0400 In-Reply-To: <20160622123941.GB2466@eudyptula.hq.kempniu.pl> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: =?UTF-8?B?TWljaGHFgiBLxJlwaWXFhA==?= Cc: Jonathan Woithe , platform-driver-x86@vger.kernel.org Am 22.06.2016 um 14:39 schrieb Micha=C5=82 K=C4=99pie=C5=84: >> Someone / Something has to generate the keycodes, even if we skip al= l >> brightness control. And I get an ACPI event for the FUJ02E3 when I p= ress >> the keys, but I don't know what to do with it (AKA which DSTD functi= on >> to call). >=20 > Can you post a DSDT dump of your machine somewhere so that we can tak= e a > look? >=20 > I played with my Lifebook E744 a bit and there is a chance it is not = as > different from the Skylake machines as I originally imagined. Earlie= r > in this thread, I already mentioned that pure ACPI brightness control > doesn't work, just like it doesn't work on Skylakes. However, input > events are correctly generated when Fn+F6 or Fn+F7 is pressed. That's no mystery, because the brightness control ACPI device (AKA =46UJ02B1 is available on e7x4 notebooks and the diriver also generates the keycodes in addition. The diff between e7x4 and e7x6 DSDT is ~43k lines or 1.3MB And the DSDT of 736 and 756 is identical. > And I am > sure these events are generated by ACPI code as booting with acpi=3Do= ff > makes the input events disappear, while also causing brightness to be > correctly adjusted. Thus, I can try to figure out which part of the > ACPI code causes the input events to be generated. That information > combined with your DSDT dump might help us in figuring out how to mak= e > it work for your machine. However, it might just as well turn out th= at > Fujitsu switched to using WMI or some opaque vendor-specific magic. The ACPI code doesn't generate the keycodes. Look at the acpi_fujitsu_notify function in drivers/platform/x86/fujitsu-laptop.c And sure, without ACPI no ACPI driver will be loaded. So without ACPI, the brightness buttons work correctly (not that's an option to run a laptop without ACPI)? Regards, Jan-Marek