From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from smtp.citrix.com ([66.165.176.89]:50456 "EHLO SMTP.CITRIX.COM"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751229AbcFWJ4R (ORCPT <rfc822;stable@vger.kernel.org>);
	Thu, 23 Jun 2016 05:56:17 -0400
Subject: Re: [Xen-devel] [PATCH] xen/pciback: Fix conf_space read/write
 overlap check.
To: Andrey Grodzovsky <andrey2805@gmail.com>,
	<xen-devel@lists.xenproject.org>
References: <1466533596-15122-1-git-send-email-andrey2805@gmail.com>
CC: <jw@quattru.com>, <stable@vger.kernel.org>,
	<david.vrabel@citrix.com>, "Jan Beulich" <JBeulich@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
From: David Vrabel <david.vrabel@citrix.com>
Message-ID: <576BB239.2010008@citrix.com>
Date: Thu, 23 Jun 2016 10:56:09 +0100
MIME-Version: 1.0
In-Reply-To: <1466533596-15122-1-git-send-email-andrey2805@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 21/06/16 19:26, Andrey Grodzovsky wrote:
> Current overlap check is evaluating to false a case where a filter field
> is fully contained (proper subset) of a r/w request.
> This change applies classical overlap check instead to include
> all the scenarios.
> 
> More specifically, for (Hilscher GmbH CIFX 50E-DP(M/S)) device
> driver the logic is such that the entire confspace  is read and
> written in 4 byte chunks.In this case as an example, CACHE_LINE_SIZE,
> LATENCY_TIMER and PCI_BIST are arriving together in one call to
> xen_pcibk_config_write with offset == 0xc and size == 4.
> With the exsisting overlap check LATENCY_TIMER field
> (offset == 0xd, length == 1) is fully contained in the write request
> and hence is excluded from write, which is incorrect.

Applied to for-linus-4.7b, thanks.

David