From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Thu, 23 Jun 2016 19:40:05 +0900 Subject: [PATCH] extcon: Check for incorrect connection type in notifier register In-Reply-To: <20160623075324.21935-1-stephen.boyd@linaro.org> References: <20160623075324.21935-1-stephen.boyd@linaro.org> Message-ID: <576BBC85.5070306@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 2016? 06? 23? 16:53, Stephen Boyd wrote: > If we call extcon_register_notifier() with the wrong cable type, > it blows up with an oops instead of returning an error code. > Let's be nice and fail gracefully given that the consumer might > not know if the cable is supported by the extcon provider. > > Signed-off-by: Stephen Boyd > --- > drivers/extcon/extcon.c | 4 ++++ > 1 file changed, 4 insertions(+) This patch has some merge conflict because the base branch is not on linux-next. But, Looks good to me. I applied it manually on extcon-next branch. Thanks, Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751885AbcFWKkL (ORCPT ); Thu, 23 Jun 2016 06:40:11 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:38653 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741AbcFWKkI (ORCPT ); Thu, 23 Jun 2016 06:40:08 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68f-f79476d000001429-06-576bbc862dfc Content-transfer-encoding: 8BIT Subject: Re: [PATCH] extcon: Check for incorrect connection type in notifier register To: Stephen Boyd References: <20160623075324.21935-1-stephen.boyd@linaro.org> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Chanwoo Choi Message-id: <576BBC85.5070306@samsung.com> Date: Thu, 23 Jun 2016 19:40:05 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 In-reply-to: <20160623075324.21935-1-stephen.boyd@linaro.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPLMWRmVeSWpSXmKPExsWyRsSkQLdtT3a4wdsd4habHl9jtbi8aw6b xdyrB5gcmD3uXNvD5rF5Sb3H501yAcxRXDYpqTmZZalF+nYJXBnHlpkXNLBWfGxIbWD8x9zF yMkhIWAisfjgazYIW0ziwr31QDYXh5DACkaJjbd+ssMUtf9exwpiCwnMYpRovwUW5xUQlPgx +R5LFyMHB7OAvMSRS9kgYWYBdYlJ8xYxQ8x5wCixbskBNpAaYYFwicbZaiA1IgJaElPu/GGB qJnEKNHws5MRotlN4m9nN9guNqCi/S9usEHs0pLoWX2OBcRmEVCV2HBiH1iNqECExKmzb8Fq OAVsJW5P+MwKcfMidonb5yQg6gUkvk0+BHanhICsxKYDUL9LShxccYNlAqPYLCTfzEL4ZhaS bxYwMq9iFE0tSC4oTkovMtYrTswtLs1L10vOz93ECIyX0/+e9e9gvHvA+hCjAAejEg9vxrGs cCHWxLLiytxDjKZAR0xklhJNzgdGZV5JvKGxmZGFqYmpsZG5pZmSOO9CqZ/BQgLpiSWp2amp BalF8UWlOanFhxiZODilGhgrdu8P2rdKeP+KUsGj+qyHdAVKHCyF/CQWOip0Sh//dXKr6NRp 9TwnjRy+3fpgHlYZurb/zrvdGr1Mbx+yGt5eP+nJI1mPz+yKnKrSVmoSUyuDYwpW6rxafPFk pPBn7YvGL9eYfvB4ZBHFYffpyMLZW5eJaSYtT0mXWC15+LmF2PSfTBMP5UYpsRRnJBpqMRcV JwIAb+1AcJICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLIsWRmVeSWpSXmKPExsVy+t9jQd22PdnhBu0/hCw2Pb7GanF51xw2 i7lXDzA5MHvcubaHzWPzknqPz5vkApijGhhtMlITU1KLFFLzkvNTMvPSbZW8g+Od403NDAx1 DS0tzJUU8hJzU22VXHwCdN0yc4AWKSmUJeaUAoUCEouLlfTtME0IDXHTtYBpjND1DQmC6zEy QAMJaxgzji0zL2hgrfjYkNrA+I+5i5GTQ0LARKL99zpWCFtM4sK99WwgtpDALEaJ9lvsIDav gKDEj8n3WLoYOTiYBeQljlzKBgkzC6hLTJq3CGgMF1D5A0aJdUsOsIHUCAuESzTOVgOpERHQ kphy5w8LRM0kRomGn52MEM1uEn87u8H2sgEV7X9xgw1il5ZEz+pzLCA2i4CqxIYT+8BqRAUi JE6dfQtWwylgK3F7wmfWCYxARyKcNwvhvFlIzlvAyLyKUSK1ILmgOCk91zAvtVyvODG3uDQv XS85P3cTIzgqn0ntYDy4y/0QowAHoxIPb8axrHAh1sSy4srcQ4wSHMxKIrwfdmWHC/GmJFZW pRblxxeV5qQWH2I0BbpxIrOUaHI+MGHklcQbGpuYGVkamRtaGBmbK4nzPv6/LkxIID2xJDU7 NbUgtQimj4mDU6qB0UBe+lSHrpXonDTxkzt4FrY/e/IhhzveW2WV98pJrAUGEx59/KP8Y4uL 55SzacwSHQ8XZlxV4fqR/FhevOLQk1ajbevcf3x9zv9g/+t9Lqcyr9kVeKSu9H9So73Gh7Pk g5TGZBPhjb/0T0n06H9MNrjfV7GjW8f7wQWWx/6V272kdicbO1qLKbEUZyQaajEXFScCAKv5 9YngAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2016년 06월 23일 16:53, Stephen Boyd wrote: > If we call extcon_register_notifier() with the wrong cable type, > it blows up with an oops instead of returning an error code. > Let's be nice and fail gracefully given that the consumer might > not know if the cable is supported by the extcon provider. > > Signed-off-by: Stephen Boyd > --- > drivers/extcon/extcon.c | 4 ++++ > 1 file changed, 4 insertions(+) This patch has some merge conflict because the base branch is not on linux-next. But, Looks good to me. I applied it manually on extcon-next branch. Thanks, Chanwoo Choi