All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Dirk Behme <dirk.behme@de.bosch.com>,
	xen-devel@lists.xenproject.org,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH] xen/arm: domain_build: DT: add clocks node to the hypervisor node
Date: Thu, 23 Jun 2016 16:02:24 +0100	[thread overview]
Message-ID: <576BFA00.4060009@arm.com> (raw)
In-Reply-To: <576AB5C3.8050209@arm.com>

On 22/06/16 16:58, Julien Grall wrote:
> On 21/06/16 11:15, Dirk Behme wrote:
>> +            printk("Failed to remember the clock node of %s\n", path);
>> +            printk("Use the Linux kernel command
>> 'clk_ignore_unused'\n");
>> +            return 0;
>
> I don't think this is tolerable. We need to fix it  once and for all.
>
> I understand that xen does not provide a realloc function. Is there
> another way we can get a rid of this limit?

Note that I would wait that we agree on the device tree bindings before 
reworking this patch. It will avoid you to waste time if we decide to 
move towards a different solution.

> I am wondering if we can use the member domain_list of dt_device_node to
> link the device having a clock property. And then latter one, allocate
> the memory + copying the data.
>
>> +        }
>> +        memcpy(&kinfo->clk.dtclocks[kinfo->clk.cnt], clocks, len);
>> +        kinfo->clk.cnt += len;
>>           return 0;
>>       }
>>

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-06-23 15:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21 10:15 [PATCH] xen/arm: domain_build: DT: add clocks node to the hypervisor node Dirk Behme
2016-06-21 10:20 ` Dirk Behme
2016-06-22 15:58 ` Julien Grall
2016-06-23 15:02   ` Julien Grall [this message]
2016-06-23 15:59     ` Dirk Behme
2016-06-23 16:02       ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576BFA00.4060009@arm.com \
    --to=julien.grall@arm.com \
    --cc=dirk.behme@de.bosch.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.