From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 2/2] xen/arm: drivers: scif: Don't overwrite firmware settings Date: Thu, 23 Jun 2016 16:10:35 +0100 Message-ID: <576BFBEB.2050005@arm.com> References: <1466596147-12166-1-git-send-email-dirk.behme@de.bosch.com> <1466596147-12166-2-git-send-email-dirk.behme@de.bosch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bG6H9-0008KA-BW for xen-devel@lists.xenproject.org; Thu, 23 Jun 2016 15:10:39 +0000 In-Reply-To: <1466596147-12166-2-git-send-email-dirk.behme@de.bosch.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Dirk Behme , xen-devel@lists.xenproject.org, Stefano Stabellini Cc: Oleksandr Tyshchenko , Iurii Konovalenko List-Id: xen-devel@lists.xenproject.org SGkgRGlyaywKCk9uIDIyLzA2LzE2IDEyOjQ5LCBEaXJrIEJlaG1lIHdyb3RlOgo+IEJlc2lkZXMg dGhlIDE0TUh6IGV4dGVybmFsIGNsb2NrLCB0aGUgU0NJRiBtaWdodCBiZSBjbG9ja2VkIGJ5IGFu Cj4gaW50ZXJuYWwgNjZNSHogY2xvY2suIElmIHRoaXMgaXMgdGhlIGNhc2UsIHRoZSBjdXJyZW50 IGNsb2NrIHNvdXJjZQo+IHNlbGVjdGlvbiBicmVha3MgdGhpcyBjb25maWd1cmF0aW9uLiBTYW1l IGZvciB0aGUgc2V0dGluZ3MgZG9uZSBieQo+IHRoZSBmaXJtd2FyZSBmb3IgZGF0YSBiaXRzLCBz dG9wIGJpdHMgYW5kIHBhcml0eS4KPgo+IENvbXBsZXRlbHkgZHJvcCB0aGlzIGFuZCByZWx5IG9u IHRoZSBzZXR0aW5ncyBkb25lIGJ5IHRoZSBmaXJtd2FyZS4KPgo+IFNpZ25lZC1vZmYtYnk6IERp cmsgQmVobWUgPGRpcmsuYmVobWVAZGUuYm9zY2guY29tPgoKUmV2aWV3ZWQtYnk6IEp1bGllbiBH cmFsbCA8anVsaWVuLmdyYWxsQGFybS5jb20+CgpSZWdhcmRzLAoKPiAtLS0KPiAgIHhlbi9kcml2 ZXJzL2NoYXIvc2NpZi11YXJ0LmMgfCA0MCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgNDAgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0t Z2l0IGEveGVuL2RyaXZlcnMvY2hhci9zY2lmLXVhcnQuYyBiL3hlbi9kcml2ZXJzL2NoYXIvc2Np Zi11YXJ0LmMKPiBpbmRleCBiYzE1N2ZlLi5mOWFlMjU3IDEwMDY0NAo+IC0tLSBhL3hlbi9kcml2 ZXJzL2NoYXIvc2NpZi11YXJ0LmMKPiArKysgYi94ZW4vZHJpdmVycy9jaGFyL3NjaWYtdWFydC5j Cj4gQEAgLTQxLDcgKzQxLDYgQEAKPiAgICNkZWZpbmUgc2NpZl93cml0ZXcodWFydCwgb2ZmLCB2 YWwpICAgIHdyaXRldygodmFsKSwgKHVhcnQpLT5yZWdzICsgKG9mZikpCj4KPiAgIHN0YXRpYyBz dHJ1Y3Qgc2NpZl91YXJ0IHsKPiAtICAgIHVuc2lnbmVkIGludCBkYXRhX2JpdHMsIHBhcml0eSwg c3RvcF9iaXRzOwo+ICAgICAgIHVuc2lnbmVkIGludCBpcnE7Cj4gICAgICAgY2hhciBfX2lvbWVt ICpyZWdzOwo+ICAgICAgIHN0cnVjdCBpcnFhY3Rpb24gaXJxYWN0aW9uOwo+IEBAIC04Nyw3ICs4 Niw2IEBAIHN0YXRpYyB2b2lkIHNjaWZfdWFydF9pbnRlcnJ1cHQoaW50IGlycSwgdm9pZCAqZGF0 YSwgc3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3MpCj4gICBzdGF0aWMgdm9pZCBfX2luaXQgc2Np Zl91YXJ0X2luaXRfcHJlaXJxKHN0cnVjdCBzZXJpYWxfcG9ydCAqcG9ydCkKPiAgIHsKPiAgICAg ICBzdHJ1Y3Qgc2NpZl91YXJ0ICp1YXJ0ID0gcG9ydC0+dWFydDsKPiAtICAgIHVpbnQxNl90IHZh bDsKPgo+ICAgICAgIC8qCj4gICAgICAgICogV2FpdCB1bnRpbCBsYXN0IGJpdCBoYXMgYmVlbiB0 cmFuc21pdHRlZC4gVGhpcyBpcyBuZWVkZWQgZm9yIGEgc21vb3RoCj4gQEAgLTEwNyw0MCArMTA1 LDYgQEAgc3RhdGljIHZvaWQgX19pbml0IHNjaWZfdWFydF9pbml0X3ByZWlycShzdHJ1Y3Qgc2Vy aWFsX3BvcnQgKnBvcnQpCj4gICAgICAgc2NpZl9yZWFkdyh1YXJ0LCBTQ0lGX1NDTFNSKTsKPiAg ICAgICBzY2lmX3dyaXRldyh1YXJ0LCBTQ0lGX1NDTFNSLCAwKTsKPgo+IC0gICAgLyogU2VsZWN0 IEJhdWQgcmF0ZSBnZW5lcmF0b3Igb3V0cHV0IGFzIGEgY2xvY2sgc291cmNlICovCj4gLSAgICBz Y2lmX3dyaXRldyh1YXJ0LCBTQ0lGX1NDU0NSLCBTQ1NDUl9DS0UxMCk7Cj4gLQo+IC0gICAgLyog U2V0dXAgcHJvdG9jb2wgZm9ybWF0IGFuZCBCYXVkIHJhdGUsIHNlbGVjdCBBc3luY2hyb25vdXMg bW9kZSAqLwo+IC0gICAgdmFsID0gMDsKPiAtICAgIEFTU0VSVCggdWFydC0+ZGF0YV9iaXRzID49 IDcgJiYgdWFydC0+ZGF0YV9iaXRzIDw9IDggKTsKPiAtICAgIGlmICggdWFydC0+ZGF0YV9iaXRz ID09IDcgKQo+IC0gICAgICAgIHZhbCB8PSBTQ1NNUl9DSFI7Cj4gLSAgICBlbHNlCj4gLSAgICAg ICAgdmFsICY9IH5TQ1NNUl9DSFI7Cj4gLQo+IC0gICAgQVNTRVJUKCB1YXJ0LT5zdG9wX2JpdHMg Pj0gMSAmJiB1YXJ0LT5zdG9wX2JpdHMgPD0gMiApOwo+IC0gICAgaWYgKCB1YXJ0LT5zdG9wX2Jp dHMgPT0gMiApCj4gLSAgICAgICAgdmFsIHw9IFNDU01SX1NUT1A7Cj4gLSAgICBlbHNlCj4gLSAg ICAgICAgdmFsICY9IH5TQ1NNUl9TVE9QOwo+IC0KPiAtICAgIEFTU0VSVCggdWFydC0+cGFyaXR5 ID49IFBBUklUWV9OT05FICYmIHVhcnQtPnBhcml0eSA8PSBQQVJJVFlfT0REICk7Cj4gLSAgICBz d2l0Y2ggKCB1YXJ0LT5wYXJpdHkgKQo+IC0gICAgewo+IC0gICAgY2FzZSBQQVJJVFlfTk9ORToK PiAtICAgICAgICB2YWwgJj0gflNDU01SX1BFOwo+IC0gICAgICAgIGJyZWFrOwo+IC0KPiAtICAg IGNhc2UgUEFSSVRZX0VWRU46Cj4gLSAgICAgICAgdmFsIHw9IFNDU01SX1BFOwo+IC0gICAgICAg IGJyZWFrOwo+IC0KPiAtICAgIGNhc2UgUEFSSVRZX09ERDoKPiAtICAgICAgICB2YWwgfD0gU0NT TVJfUEUgfCBTQ1NNUl9PREQ7Cj4gLSAgICAgICAgYnJlYWs7Cj4gLSAgICB9Cj4gLSAgICBzY2lm X3dyaXRldyh1YXJ0LCBTQ0lGX1NDU01SLCB2YWwpOwo+IC0KPiAgICAgICAvKiBTZXR1cCB0cmln Z2VyIGxldmVsIGZvciBUWC9SWCBGSUZPcyAqLwo+ICAgICAgIHNjaWZfd3JpdGV3KHVhcnQsIFND SUZfU0NGQ1IsIFNDRkNSX1JUUkcxMSB8IFNDRkNSX1RUUkcxMSk7Cj4KPiBAQCAtMjgzLDEwICsy NDcsNiBAQCBzdGF0aWMgaW50IF9faW5pdCBzY2lmX3VhcnRfaW5pdChzdHJ1Y3QgZHRfZGV2aWNl X25vZGUgKmRldiwKPgo+ICAgICAgIHVhcnQgPSAmc2NpZl9jb207Cj4KPiAtICAgIHVhcnQtPmRh dGFfYml0cyA9IDg7Cj4gLSAgICB1YXJ0LT5wYXJpdHkgICAgPSBQQVJJVFlfTk9ORTsKPiAtICAg IHVhcnQtPnN0b3BfYml0cyA9IDE7Cj4gLQo+ICAgICAgIHJlcyA9IGR0X2RldmljZV9nZXRfYWRk cmVzcyhkZXYsIDAsICZhZGRyLCAmc2l6ZSk7Cj4gICAgICAgaWYgKCByZXMgKQo+ICAgICAgIHsK PgoKLS0gCkp1bGllbiBHcmFsbAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9y ZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK