From: Eli Billauer <eli.billauer@gmail.com>
To: Colin Ian King <colin.king@canonical.com>, Joe Perches <joe@perches.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"
Date: Thu, 23 Jun 2016 23:09:13 +0300 [thread overview]
Message-ID: <576C41E9.30304@gmail.com> (raw)
In-Reply-To: <576C3DAD.60107@canonical.com>
OK, I'll submit a patch quite soon. Thanks again.
Eli
On 23/06/16 22:51, Colin Ian King wrote:
> On 23/06/16 20:23, Eli Billauer wrote:
>
>> This is getting increasingly embarrassing. I suppose a single patch,
>> fixing both silly mistakes (of mine), would be in place.
>>
>> Colin, would you prefer to submit a patch with both issues fixed
>> yourself, or should I take care of it?
>>
> Eli, I don't mind if you fix it up.
>
>
>> Thanks, both of you.
>> Eli
>>
>> On 23/06/16 22:05, Joe Perches wrote:
>>
>>> On Thu, 2016-06-23 at 18:48 +0100, Colin King wrote:
>>>
>>>
>>>> trivial fix to spelling mistake in dev_err message
>>>>
>>>>
>>> []
>>>
>>>
>>>> diff --git a/drivers/char/xillybus/xillybus_core.c
>>>> b/drivers/char/xillybus/xillybus_core.c
>>>>
>>>>
>>> []
>>>
>>>
>>>> @@ -658,7 +658,7 @@ static int xilly_obtain_idt(struct xilly_endpoint
>>>> *endpoint)
>>>> /* Check version number. Accept anything below 0x82 for now. */
>>>> if (*version> 0x82) {
>>>>
>>>>
>>> trivia: code doesn't match comment above it.
>>>
>>>
>>>
>>>> dev_err(endpoint->dev,
>>>> - "No support for IDT version 0x%02x. Maybe the xillybus
>>>> driver needs an upgarde. Aborting.\n",
>>>> + "No support for IDT version 0x%02x. Maybe the xillybus
>>>> driver needs an upgrade. Aborting.\n",
>>>> *version);
>>>> return -ENODEV;
>>>> }
>>>>
>>>>
>>>
>>>
>>
>
prev parent reply other threads:[~2016-06-23 20:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 17:48 [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade" Colin King
2016-06-23 19:00 ` Eli Billauer
2016-06-23 19:05 ` Joe Perches
2016-06-23 19:23 ` Eli Billauer
2016-06-23 19:51 ` Colin Ian King
2016-06-23 20:09 ` Eli Billauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576C41E9.30304@gmail.com \
--to=eli.billauer@gmail.com \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.