From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751587AbcFXAN7 (ORCPT ); Thu, 23 Jun 2016 20:13:59 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:64559 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbcFXAN6 (ORCPT ); Thu, 23 Jun 2016 20:13:58 -0400 Subject: Re: [PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is not set To: Lee Jones , Andy Shevchenko , Mika Westerberg References: <1466727074-14931-1-git-send-email-vladimir_zapolskiy@mentor.com> CC: From: Vladimir Zapolskiy Message-ID: <576C7B43.7070003@mentor.com> Date: Fri, 24 Jun 2016 03:13:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Icedove/38.1.0 MIME-Version: 1.0 In-Reply-To: <1466727074-14931-1-git-send-email-vladimir_zapolskiy@mentor.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [137.202.0.76] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24.06.2016 03:11, Vladimir Zapolskiy wrote: > If kernel build configuration has enabled CONFIG_PM and unset > CONFIG_PM_SLEEP, then intel-lpss-pci.c and intel-lpss-acpi.c can not > be compiled due to a missing INTEL_LPSS_SLEEP_PM_OPS macro > declaration: > > drivers/mfd/intel-lpss-pci.c:63:8: error: undefined identifier 'INTEL_LPSS_SLEEP_PM_OPS' > drivers/mfd/intel-lpss-pci.c:63:58: error: ‘INTEL_LPSS_SLEEP_PM_OPS’ undeclared here (not in a function) > > Fixes: d35dbf0dbaa7 ("mfd: Add support for Intel Sunrisepoint LPSS devices") Oops, weird fixed commit id, it should be Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices") > Signed-off-by: Vladimir Zapolskiy > --- > drivers/mfd/intel-lpss.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mfd/intel-lpss.h b/drivers/mfd/intel-lpss.h > index 764dc0d..0dcea9e 100644 > --- a/drivers/mfd/intel-lpss.h > +++ b/drivers/mfd/intel-lpss.h > @@ -44,6 +44,8 @@ int intel_lpss_resume(struct device *dev); > .thaw = intel_lpss_resume, \ > .poweroff = intel_lpss_suspend, \ > .restore = intel_lpss_resume, > +#else > +#define INTEL_LPSS_SLEEP_PM_OPS > #endif > > #define INTEL_LPSS_RUNTIME_PM_OPS \ > -- Best wishes, Vladimir