Re: [PATCH v4 1/5] mfd: tps65217: Add support for IRQs

[Grygorii Strashko <grygorii.strashko@ti.com>]

On 06/20/2016 01:50 PM, Marcin Niestroj wrote:
> Add support for handling IRQs: power button, AC and USB power state
> changes. Mask and interrupt bits are shared within one register, which
> prevents us to use regmap_irq implementation. New irq_domain is created in
> order to add interrupt handling for each tps65217's subsystem. IRQ
> resources have been added for charger subsystem to be able to notify about
> AC and USB state changes.
>
> Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> ---
> Changes v3 -> v4 (suggested by Grygorii):
>   * Add irq_set_parent() during irq init
>   * Remove hardcoded IRQ trigger type, rely on DT bindings instead
>
> Changes v2 -> v3 (suggested by Lee):
>   * Alphabetical reorder of includes
>   * Rename enum tps65217_irqs -> tps65217_irq_type, so we won't confuse
>     it with structure object with the same name.
>   * Fix inconsistent order of irq_enable and irq_disable
>   * Remove redundant 'else' when returning from tps65217_irq_thread
>
> Changes v1 -> v2: none
>
>   drivers/mfd/Kconfig          |   1 +
>   drivers/mfd/tps65217.c       | 195 +++++++++++++++++++++++++++++++++++++++++--
>   include/linux/mfd/tps65217.h |  12 +++
>   3 files changed, 200 insertions(+), 8 deletions(-)
>

Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>



-- 
regards,
-grygorii