From mboxrd@z Thu Jan 1 00:00:00 1970 From: raashidmuhammed@zilogic.com (raashidmuhammed) Date: Fri, 24 Jun 2016 19:26:45 +0530 Subject: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes. In-Reply-To: <20160624134010.GN5809@piout.net> References: <1466775069-606-1-git-send-email-raashidmuhammed@zilogic.com> <1466775069-606-2-git-send-email-raashidmuhammed@zilogic.com> <20160624134010.GN5809@piout.net> Message-ID: <576D3C1D.1050107@zilogic.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/24/2016 07:10 PM, Alexandre Belloni wrote: > Hi, > > On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote : >> Add power led node and rename status led node. >> > Well, I'm ok with the change but this does more: > >> Signed-off-by: Raashid Muhammed >> Reviewed-by: Vijay Kumar B. >> --- >> arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++---- >> 1 file changed, 9 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts >> index be409f2..814753a 100644 >> --- a/arch/arm/boot/dts/at91-sam9_l9260.dts >> +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts >> @@ -106,11 +106,16 @@ >> leds { >> compatible = "gpio-leds"; >> >> - b0 { >> - label = "b0"; >> - gpios = <&pioA 6 GPIO_ACTIVE_HIGH>; >> - linux,default-trigger = "heartbeat"; >> + pwr_led { >> + label = "sam9-l9260:yellow:pwr"; >> + gpios = <&pioA 9 GPIO_ACTIVE_HIGH>; >> + linux,default-trigger = "cpu0"; >> }; >> >> + status_led { >> + label = "sam9-l9260:green:status"; >> + gpios = <&pioA 6 GPIO_ACTIVE_LOW>; >> + linux,default-trigger = "timer"; > This trigger is also switched from heartbeat to timer, is this > intentional? > Yes, that is intentional. I should have included that in the commit message. From mboxrd@z Thu Jan 1 00:00:00 1970 From: raashidmuhammed Subject: Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes. Date: Fri, 24 Jun 2016 19:26:45 +0530 Message-ID: <576D3C1D.1050107@zilogic.com> References: <1466775069-606-1-git-send-email-raashidmuhammed@zilogic.com> <1466775069-606-2-git-send-email-raashidmuhammed@zilogic.com> <20160624134010.GN5809@piout.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160624134010.GN5809-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexandre Belloni Cc: nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org, plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 06/24/2016 07:10 PM, Alexandre Belloni wrote: > Hi, > > On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote : >> Add power led node and rename status led node. >> > Well, I'm ok with the change but this does more: > >> Signed-off-by: Raashid Muhammed >> Reviewed-by: Vijay Kumar B. >> --- >> arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++---- >> 1 file changed, 9 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts >> index be409f2..814753a 100644 >> --- a/arch/arm/boot/dts/at91-sam9_l9260.dts >> +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts >> @@ -106,11 +106,16 @@ >> leds { >> compatible = "gpio-leds"; >> >> - b0 { >> - label = "b0"; >> - gpios = <&pioA 6 GPIO_ACTIVE_HIGH>; >> - linux,default-trigger = "heartbeat"; >> + pwr_led { >> + label = "sam9-l9260:yellow:pwr"; >> + gpios = <&pioA 9 GPIO_ACTIVE_HIGH>; >> + linux,default-trigger = "cpu0"; >> }; >> >> + status_led { >> + label = "sam9-l9260:green:status"; >> + gpios = <&pioA 6 GPIO_ACTIVE_LOW>; >> + linux,default-trigger = "timer"; > This trigger is also switched from heartbeat to timer, is this > intentional? > Yes, that is intentional. I should have included that in the commit message. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751690AbcFXN5I (ORCPT ); Fri, 24 Jun 2016 09:57:08 -0400 Received: from li2-213.members.linode.com ([69.56.173.213]:54416 "EHLO mail.zilogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374AbcFXN5G (ORCPT ); Fri, 24 Jun 2016 09:57:06 -0400 Subject: Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes. To: Alexandre Belloni References: <1466775069-606-1-git-send-email-raashidmuhammed@zilogic.com> <1466775069-606-2-git-send-email-raashidmuhammed@zilogic.com> <20160624134010.GN5809@piout.net> Cc: nicolas.ferre@atmel.com, plagnioj@jcrosoft.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: raashidmuhammed Message-ID: <576D3C1D.1050107@zilogic.com> Date: Fri, 24 Jun 2016 19:26:45 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160624134010.GN5809@piout.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/24/2016 07:10 PM, Alexandre Belloni wrote: > Hi, > > On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote : >> Add power led node and rename status led node. >> > Well, I'm ok with the change but this does more: > >> Signed-off-by: Raashid Muhammed >> Reviewed-by: Vijay Kumar B. >> --- >> arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++---- >> 1 file changed, 9 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts >> index be409f2..814753a 100644 >> --- a/arch/arm/boot/dts/at91-sam9_l9260.dts >> +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts >> @@ -106,11 +106,16 @@ >> leds { >> compatible = "gpio-leds"; >> >> - b0 { >> - label = "b0"; >> - gpios = <&pioA 6 GPIO_ACTIVE_HIGH>; >> - linux,default-trigger = "heartbeat"; >> + pwr_led { >> + label = "sam9-l9260:yellow:pwr"; >> + gpios = <&pioA 9 GPIO_ACTIVE_HIGH>; >> + linux,default-trigger = "cpu0"; >> }; >> >> + status_led { >> + label = "sam9-l9260:green:status"; >> + gpios = <&pioA 6 GPIO_ACTIVE_LOW>; >> + linux,default-trigger = "timer"; > This trigger is also switched from heartbeat to timer, is this > intentional? > Yes, that is intentional. I should have included that in the commit message.