From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [RFC 0/5] rework fences on struct sync_file Date: Fri, 24 Jun 2016 16:14:10 +0200 Message-ID: <576D4032.3000001@vodafone.de> References: <1466695790-2833-1-git-send-email-gustavo@padovan.org> <576CFD0B.6000501@amd.com> <20160624131724.GA2503@joana> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from pegasos-out.vodafone.de (pegasos-out.vodafone.de [80.84.1.38]) by gabe.freedesktop.org (Postfix) with ESMTP id 42FB96E00B for ; Fri, 24 Jun 2016 14:14:21 +0000 (UTC) In-Reply-To: <20160624131724.GA2503@joana> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan , =?UTF-8?Q?Christian_K=c3=b6nig?= , dri-devel@lists.freedesktop.org, marcheu@google.com, Daniel Stone , seanpaul@google.com, Daniel Vetter , linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com, Gustavo Padovan , John Harrison , m.chehab@samsung.com List-Id: dri-devel@lists.freedesktop.org QW0gMjQuMDYuMjAxNiB1bSAxNToxNyBzY2hyaWViIEd1c3Rhdm8gUGFkb3ZhbjoKPiBIaSBDaHJp c3RpYW4sCj4KPiAyMDE2LTA2LTI0IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdA YW1kLmNvbT46Cj4KPj4gQW0gMjMuMDYuMjAxNiB1bSAxNzoyOSBzY2hyaWViIEd1c3Rhdm8gUGFk b3ZhbjoKPj4+IEZyb206IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9y YS5jby51az4KPj4+Cj4+PiBIaSBhbGwsCj4+Pgo+Pj4gVGhpcyBpcyBhbiBhdHRlbXB0IHRvIGlt cHJvdmUgZmVuY2Ugc3VwcG9ydCBvbiBTeW5jIEZpbGUuIFRoZSBiYXNpYyBpZGVhCj4+PiBpcyB0 byBoYXZlIG9ubHkgc3luY19maWxlLT5mZW5jZSBhbmQgc3RvcmUgYWxsIGZlbmNlcyB0aGVyZSwg ZWl0aGVyIGFzCj4+PiBub3JtYWwgZmVuY2VzIG9yIGZlbmNlX2FycmF5cy4gVGhhdCB3YXkgd2Ug Y2FuIHJlbW92ZSBzb21lIHBvdGVudGlhbAo+Pj4gZHVwbGljYXRpb24gd2hlbiB1c2luZyBmZW5j ZV9hcnJheSB3aXRoIHN5bmNfZmlsZTogdGhlIGR1cGxpY2F0aW9uIG9mIHRoZSBhcnJheQo+Pj4g b2YgZmVuY2VzIGFuZCB0aGUgZHVwbGljYXRpb24gb2YgZmVuY2VfYWRkX2NhbGxiYWNrKCkgZm9y IGFsbCBmZW5jZXMuCj4+Pgo+Pj4gTm93IHdoZW4gY3JlYXRpbmcgYSBuZXcgc3luY19maWxlIGR1 cmluZyB0aGUgbWVyZ2UgcHJvY2VzcyBzeW5jX2ZpbGVfc2V0X2ZlbmNlKCkKPj4+IHdpbGwgc2V0 IHN5bmNfZmlsZS0+ZmVuY2UgYmFzZWQgb24gdGhlIG51bWJlciBvZiBmZW5jZXMgZm9yIHRoYXQg c3luY19maWxlLiBJZgo+Pj4gdGhlcmUgaXMgbW9yZSB0aGFuIG9uZSBmZW5jZSBhIGZlbmNlX2Fy cmF5IGlzIGNyZWF0ZWQuIE9uZSBpbXBvcnRhbnQgYWR2YW50YWdlCj4+PiBhcHByb2FjaCBpcyB0 aGF0IHdlIG9ubHkgYWRkIG9uZSBmZW5jZSBjYWxsYmFjayBub3csIG5vIG1hdHRlciBob3cgbWFu eSBmZW5jZXMKPj4+IHRoZXJlIGFyZSBpbiBhIHN5bmNfZmlsZSAtIHRoZSBpbmRpdmlkdWFsIGNh bGxiYWNrcyBhcmUgYWRkZWQgYnkgZmVuY2VfYXJyYXkuCj4+Pgo+Pj4gVHdvIGZlbmNlIG9wcyBo YWQgdG8gYmUgY3JlYXRlZCB0byBoZWxwIGFic3RyYWN0IHRoZSBkaWZmZXJlbmNlIGJldHdlZW4g aGFuZGxpbmcKPj4+IGZlbmNlcyBhbmQgZmVuY2VzX2FycmF5czogLnRlYXJkb3duKCkgYW5kIC5n ZXRfZmVuY2VzKCkuIFRoZSBmb3JtZXIgcnVuIG5lZWRlZAo+Pj4gb24gZmVuY2VfYXJyYXksIGFu ZCB0aGUgbGF0dGVyIGp1c3QgcmV0dXJuIGEgY29weSBvZiBhbGwgZmVuY2VzIGluIHRoZSBmZW5j ZS4KPj4+IEknbSBub3Qgc28gc3VyZSBhYm91dCBhZGRpbmcgdGhvc2UgdHdvLCBzcGVhY2lhbGx5 IC5nZXRfZmVuY2VzKCkuIFdoYXQgZG8geW91Cj4+PiB0aGluaz8KPj4gQ2xlYXJseSBub3QgYSBn b29kIGlkZWEgdG8gYWRkIHRoaXMgYSBmZW5jZSBvcHMsIGNhdXNlIHRob3NlIGFyZSBzcGVjaWFs aXplZAo+PiBmdW5jdGlvbnMgZm9yIG9ubHkgYSBjZXJ0YWluIGZlbmNlIGltcGxlbWVudGF0aW9u ICh0aGUgZmVuY2VfYXJyYXkpLgo+IEFyZSB5b3UgcmVmZXJpbmcgb25seSB0byAuZ2V0X2ZlbmNl cygpPwoKVGhhdCBjb21tZW50IHdhcyBvbmx5IGZvciB0aGUgZ2V0X2ZlbmNlcygpIG9wZXJhdGlv biwgYnV0IHRoZSB0ZWFyZG93bigpIApjYWxsYmFjayBsb29rcyB2ZXJ5IHN1c3BpY2lvdXMgdG8g bWUgYXMgd2VsbC4KCkNhbiB5b3UgZXhwbGFpbiBvbmNlIG1vcmUgd2h5IHRoYXQgc2hvdWxkIGJl IG5lY2Vzc2FyeT8KClJlZ2FyZHMsCkNocmlzdGlhbi4KCj4KPj4gV2hhdCB5b3Ugc2hvdWxkIGRv IGlzIHRyeSB0byBjYXN0IHRoZSBmZW5jZSBpbiB5b3VyIHN5bmMgZmlsZSB1c2luZwo+PiB0b19m ZW5jZV9hcnJheSgpIGFuZCB0aGVuIHlvdSBjYW4gYWNjZXNzIHRoZSBmZW5jZXMgaW4gdGhlIGFy cmF5Lgo+IFllcywgdGhhdCBzZWVtcyBhIGJldHRlciBpZGVhIEkgdGhpbmsuIFRoZSBpbml0aWFs IGlkZWEgd2FzIHRvIGFic3RyYWN0Cj4gdGhlIGRpZmZlcmVuY2UgYXMgbXVjaCBhcyBwb3NzaWJs ZSwgYnV0IGl0IGRvZXNuJ3Qgc2VlbSByZWFsbHkgd29ydGgKPiBmb3IgLmdldF9mZW5jZXMoKS4K Pgo+IAlHdXN0YXZvCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751817AbcFXOOY (ORCPT ); Fri, 24 Jun 2016 10:14:24 -0400 Received: from pegasos-out.vodafone.de ([80.84.1.38]:48330 "EHLO pegasos-out.vodafone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751776AbcFXOOX (ORCPT ); Fri, 24 Jun 2016 10:14:23 -0400 X-Spam-Flag: NO X-Spam-Score: 0.2 Authentication-Results: rohrpostix1.prod.vfnet.de (amavisd-new); dkim=pass header.i=@vodafone.de X-DKIM: OpenDKIM Filter v2.6.8 pegasos-out.vodafone.de 7A908261A8B Subject: Re: [RFC 0/5] rework fences on struct sync_file To: Gustavo Padovan , =?UTF-8?Q?Christian_K=c3=b6nig?= , dri-devel@lists.freedesktop.org, marcheu@google.com, Daniel Stone , seanpaul@google.com, Daniel Vetter , linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com, Gustavo Padovan , John Harrison , m.chehab@samsung.com References: <1466695790-2833-1-git-send-email-gustavo@padovan.org> <576CFD0B.6000501@amd.com> <20160624131724.GA2503@joana> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <576D4032.3000001@vodafone.de> Date: Fri, 24 Jun 2016 16:14:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160624131724.GA2503@joana> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 24.06.2016 um 15:17 schrieb Gustavo Padovan: > Hi Christian, > > 2016-06-24 Christian König : > >> Am 23.06.2016 um 17:29 schrieb Gustavo Padovan: >>> From: Gustavo Padovan >>> >>> Hi all, >>> >>> This is an attempt to improve fence support on Sync File. The basic idea >>> is to have only sync_file->fence and store all fences there, either as >>> normal fences or fence_arrays. That way we can remove some potential >>> duplication when using fence_array with sync_file: the duplication of the array >>> of fences and the duplication of fence_add_callback() for all fences. >>> >>> Now when creating a new sync_file during the merge process sync_file_set_fence() >>> will set sync_file->fence based on the number of fences for that sync_file. If >>> there is more than one fence a fence_array is created. One important advantage >>> approach is that we only add one fence callback now, no matter how many fences >>> there are in a sync_file - the individual callbacks are added by fence_array. >>> >>> Two fence ops had to be created to help abstract the difference between handling >>> fences and fences_arrays: .teardown() and .get_fences(). The former run needed >>> on fence_array, and the latter just return a copy of all fences in the fence. >>> I'm not so sure about adding those two, speacially .get_fences(). What do you >>> think? >> Clearly not a good idea to add this a fence ops, cause those are specialized >> functions for only a certain fence implementation (the fence_array). > Are you refering only to .get_fences()? That comment was only for the get_fences() operation, but the teardown() callback looks very suspicious to me as well. Can you explain once more why that should be necessary? Regards, Christian. > >> What you should do is try to cast the fence in your sync file using >> to_fence_array() and then you can access the fences in the array. > Yes, that seems a better idea I think. The initial idea was to abstract > the difference as much as possible, but it doesn't seem really worth > for .get_fences(). > > Gustavo > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel