From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54379)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1bGTBr-00065T-EM
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 11:38:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1bGTBm-0001X5-8X
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 11:38:42 -0400
Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:35733)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1bGTBl-0001Wp-W5
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 11:38:38 -0400
Received: by mail-lf0-x242.google.com with SMTP id w130so22021044lfd.2
	for <qemu-devel@nongnu.org>; Fri, 24 Jun 2016 08:38:37 -0700 (PDT)
References: <1464986428-6739-1-git-send-email-alex.bennee@linaro.org>
	<1464986428-6739-7-git-send-email-alex.bennee@linaro.org>
From: Sergey Fedorov <serge.fdrv@gmail.com>
Message-ID: <576D53FB.6050405@gmail.com>
Date: Fri, 24 Jun 2016 18:38:35 +0300
MIME-Version: 1.0
In-Reply-To: <1464986428-6739-7-git-send-email-alex.bennee@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RFC v3 06/19] tcg: comment on which functions
 have to be called with tb_lock held
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, mttcg@listserver.greensocs.com, qemu-devel@nongnu.org, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, cota@braap.org, bobby.prani@gmail.com
Cc: mark.burton@greensocs.com, pbonzini@redhat.com, jan.kiszka@siemens.com, rth@twiddle.net, peter.maydell@linaro.org, claudio.fontana@huawei.com, Peter Crosthwaite <crosthwaite.peter@gmail.com>

On 03/06/16 23:40, Alex Bennée wrote:
> diff --git a/translate-all.c b/translate-all.c
> index e3f44d9..8b162ff 100644
> --- a/translate-all.c
> +++ b/translate-all.c
(snip)
> @@ -347,8 +349,10 @@ bool cpu_restore_state(CPUState *cpu, uintptr_t retaddr)
>          cpu_restore_state_from_tb(cpu, tb, retaddr);
>          if (tb->cflags & CF_NOCACHE) {
>              /* one-shot translation, invalidate it immediately */
> +            tb_lock();
>              tb_phys_invalidate(tb, -1);
>              tb_free(tb);
> +            tb_unlock();

Looks like this belongs to another patch ;-)

>          }
>          return true;
>      }
>

Kind regards,
Sergey