From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751682AbcFXWCs (ORCPT ); Fri, 24 Jun 2016 18:02:48 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:33856 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751379AbcFXWCr (ORCPT ); Fri, 24 Jun 2016 18:02:47 -0400 Subject: Re: [PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is not set To: Andy Shevchenko , Lee Jones , Mika Westerberg References: <1466727074-14931-1-git-send-email-vladimir_zapolskiy@mentor.com> <1466756938.30123.272.camel@linux.intel.com> CC: From: Vladimir Zapolskiy Message-ID: <576DADFF.3040206@mentor.com> Date: Sat, 25 Jun 2016 01:02:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Icedove/38.1.0 MIME-Version: 1.0 In-Reply-To: <1466756938.30123.272.camel@linux.intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [137.202.0.76] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24.06.2016 11:28, Andy Shevchenko wrote: > On Fri, 2016-06-24 at 03:11 +0300, Vladimir Zapolskiy wrote: >> If kernel build configuration has enabled CONFIG_PM and unset >> CONFIG_PM_SLEEP, then intel-lpss-pci.c and intel-lpss-acpi.c can not >> be compiled due to a missing INTEL_LPSS_SLEEP_PM_OPS macro >> declaration: >> >> drivers/mfd/intel-lpss-pci.c:63:8: error: undefined identifier >> 'INTEL_LPSS_SLEEP_PM_OPS' >> drivers/mfd/intel-lpss-pci.c:63:58: error: ‘INTEL_LPSS_SLEEP_PM_OPS’ >> undeclared here (not in a function) > > And may I ask what ancient kernel you are using? > > commit 47b91923ea41288751e83a5b080576085a831333 > Author: Andy Shevchenko > Date: Mon Sep 14 11:32:47 2015 +0300 > > mfd: intel-lpss: Fix build error when !CONFIG_PM_SLEEP The original driver was backported to 4.1 Thanks for the reference to a fixup, I'll backport it as well. Lee, please ignore this change. -- With best wishes, Vladimir