From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751661AbcFYAIo (ORCPT <rfc822;w@1wt.eu>);
	Fri, 24 Jun 2016 20:08:44 -0400
Received: from lists.s-osg.org ([54.187.51.154]:47571 "EHLO lists.s-osg.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751101AbcFYAIm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 24 Jun 2016 20:08:42 -0400
Subject: Re: [PATCH] selftests/lib: set printf.sh executable
To: SeongJae Park <sj38.park@gmail.com>, Kees Cook <keescook@chromium.org>
References: <1466242119-3424-1-git-send-email-sj38.park@gmail.com>
 <CAGXu5jLR7AitEHeKNzBiBrDVM2k=XWC2w1PpOy-u9SkMecv4eg@mail.gmail.com>
 <CAEjAshorVMQCwbMws1vwmVtmy-=XZHmaJAMOEbq5ueFfTytDOw@mail.gmail.com>
Cc: adriy.shevchenko@linux.intel.com, linux-kselftest@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        shuah Khan <shuahkh@osg.samsung.com>
From: Shuah Khan <shuahkh@osg.samsung.com>
Message-ID: <576DCB88.5090400@osg.samsung.com>
Date: Fri, 24 Jun 2016 18:08:40 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <CAEjAshorVMQCwbMws1vwmVtmy-=XZHmaJAMOEbq5ueFfTytDOw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi SeongJae Park,

Thanks for the ping.

On 06/24/2016 05:56 PM, SeongJae Park wrote:
> Shuah,
> 
> 
> May I ask your opinion about this patch?
> 
> 
> Thanks,
> SeongJae Park
> 
> On Sun, Jun 19, 2016 at 2:50 AM, Kees Cook <keescook@chromium.org> wrote:
>> On Sat, Jun 18, 2016 at 2:28 AM, SeongJae Park <sj38.park@gmail.com> wrote:
>>> Test for test_printf module fails always because the test program,
>>> printf.sh, has no execution permission.  This commit adds execution
>>> permission to it.
>>>
>>> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
>>
>> Acked-by: Kees Cook <keescook@chromium.org>
>>
>> (Is this mode change sufficient, or does the selftest infrastructure
>> need to explicitly set it executable when running?)

This is good and makes it consistent with bitmap.sh the other
shell script in this test suite. I will get this into 4.8-rc1

thanks,
-- Shuah

>>
>> -Kees
>>
>>
>>> ---
>>>  tools/testing/selftests/lib/printf.sh | 0
>>>  1 file changed, 0 insertions(+), 0 deletions(-)
>>>  mode change 100644 => 100755 tools/testing/selftests/lib/printf.sh
>>>
>>> diff --git a/tools/testing/selftests/lib/printf.sh b/tools/testing/selftests/lib/printf.sh
>>> old mode 100644
>>> new mode 100755
>>> --
>>> 1.9.1
>>>
>>
>>
>>
>> --
>> Kees Cook
>> Chrome OS & Brillo Security