From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH v6] leds: documentation: 'ide-disk' to 'disk-activity' Date: Mon, 27 Jun 2016 09:04:13 +0200 Message-ID: <5770CFED.4090300@samsung.com> References: <20160624171704.13399-1-linz@li-pro.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <20160624171704.13399-1-linz-LlUBiLVY8XKsTnJN9+BGXg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephan Linz Cc: linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Joseph Jezak , =?UTF-8?B?SsO2cmcgU29tbWVy?= , Mark Rutland , Richard Purdie , Rob Herring , Jonathan Corbet , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-ide@vger.kernel.org Hi Stephan, On 06/24/2016 07:16 PM, Stephan Linz wrote: > Cc: Joseph Jezak > Cc: J=C3=B6rg Sommer > Cc: Mark Rutland > Signed-off-by: Stephan Linz > Acked-by: Rob Herring > Signed-off-by: Jacek Anaszewski > --- > Changes in v6: > - Reorganize v5. > > Changes in v5: > - Keep documentation for the old 'ide-disk' device tree > binding, but mark as deprecated and refer to the new > trigger 'disk-activity'. > > Changes in v4: > - Keep the 'ide-disk' trigger and add a second one > for 'disk-activity'. > > Changes in v3: > - Port to kernel 4.x > - Split into platform independent and dependent parts. > > v2: https://patchwork.ozlabs.org/patch/117485/ > v1: http://dev.gentoo.org/~josejx/ata.patch > --- > Documentation/devicetree/bindings/leds/common.txt | 4 +++- > Documentation/devicetree/bindings/leds/leds-gpio.txt | 4 ++-- > Documentation/laptops/asus-laptop.txt | 2 +- > Documentation/leds/leds-class.txt | 2 +- > 4 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Docu= mentation/devicetree/bindings/leds/common.txt > index af10678..93ef6e6 100644 > --- a/Documentation/devicetree/bindings/leds/common.txt > +++ b/Documentation/devicetree/bindings/leds/common.txt > @@ -26,7 +26,9 @@ Optional properties for child nodes: > "default-on" - LED will turn on (but for leds-gpio see "defaul= t-state" > property in Documentation/devicetree/bindings/gpio/led.txt) > "heartbeat" - LED "double" flashes at a load average based rat= e > - "ide-disk" - LED indicates disk activity > + "disk-activity" - LED indicates disk activity > + "ide-disk" - LED indicates IDE disk activity (deprecated), > + in new implementations use "disk-activity" > "timer" - LED flashes at a fixed, configurable rate > > - led-max-microamp : Maximum LED supply current in microamperes. Th= is property > diff --git a/Documentation/devicetree/bindings/leds/leds-gpio.txt b/D= ocumentation/devicetree/bindings/leds/leds-gpio.txt > index cbbeb18..5b1b43a 100644 > --- a/Documentation/devicetree/bindings/leds/leds-gpio.txt > +++ b/Documentation/devicetree/bindings/leds/leds-gpio.txt > @@ -33,9 +33,9 @@ Examples: > leds { > compatible =3D "gpio-leds"; > hdd { > - label =3D "IDE Activity"; > + label =3D "Disk Activity"; > gpios =3D <&mcu_pio 0 GPIO_ACTIVE_LOW>; > - linux,default-trigger =3D "ide-disk"; > + linux,default-trigger =3D "disk-activity"; > }; > > fault { > diff --git a/Documentation/laptops/asus-laptop.txt b/Documentation/la= ptops/asus-laptop.txt > index 79a1bc6..5f28587 100644 > --- a/Documentation/laptops/asus-laptop.txt > +++ b/Documentation/laptops/asus-laptop.txt > @@ -72,7 +72,7 @@ LEDs > echo 1 > /sys/class/leds/asus::mail/brightness > will switch the mail LED on. > You can also know if they are on/off by reading their content and= use > - kernel triggers like ide-disk or heartbeat. > + kernel triggers like disk-activity or heartbeat. > > Backlight > --------- > diff --git a/Documentation/leds/leds-class.txt b/Documentation/leds/l= eds-class.txt > index 44f5e6b..f1f7ec9 100644 > --- a/Documentation/leds/leds-class.txt > +++ b/Documentation/leds/leds-class.txt > @@ -11,7 +11,7 @@ brightness support so will just be turned on for no= n-zero brightness settings. > The class also introduces the optional concept of an LED trigger. A= trigger > is a kernel based source of led events. Triggers can either be simp= le or > complex. A simple trigger isn't configurable and is designed to slo= t into > -existing subsystems with minimal additional code. Examples are the i= de-disk, > +existing subsystems with minimal additional code. Examples are the d= isk-activity, > nand-disk and sharpsl-charge triggers. With led triggers disabled, = the code > optimises away. > > Applied, thanks. --=20 Best regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751986AbcF0HEV (ORCPT ); Mon, 27 Jun 2016 03:04:21 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:63357 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751248AbcF0HET (ORCPT ); Mon, 27 Jun 2016 03:04:19 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed X-AuditID: cbfec7f4-f796c6d000001486-a8-5770cfeee72d Content-transfer-encoding: 8BIT Message-id: <5770CFED.4090300@samsung.com> Date: Mon, 27 Jun 2016 09:04:13 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 To: Stephan Linz Cc: linux-leds@vger.kernel.org, linux-ide@vger.kernel.org, Joseph Jezak , =?UTF-8?B?SsO2cmcgU29tbWVy?= , Mark Rutland , Richard Purdie , Rob Herring , Jonathan Corbet , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v6] leds: documentation: 'ide-disk' to 'disk-activity' References: <20160624171704.13399-1-linz@li-pro.net> In-reply-to: <20160624171704.13399-1-linz@li-pro.net> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHLMWRmVeSWpSXmKPExsVy+t/xa7rvzheEG9x/oW/x5EA7o8X8I+dY Lc4va2e1OPegh9liYdsSFotjOx4xWVzeNYfNYuubdYwWV18vYrFYev0ik0Xr3iPsFrt3PWV1 4PFY0ryZyWPNvDWMHpe/v2H22LSqk81j99tUj8V9k1k99sz/werxeZNcAEcUl01Kak5mWWqR vl0CV8bmzStZC04qVNzfvIS9gXG+VBcjB4eEgInExRV1XYycQKaYxIV769m6GLk4hASWMkrc /fqGESTBKyAo8WPyPRaQemYBeYkjl7JBwswCZhKPWtYxQ9Q/Y5SY8GQCG0S9lsSi/7/YQWwW AVWJpvY3LCA2m4ChxM8Xr5lAbFGBCIk/p/exgtgiAkoSk560soMMYhb4wySx/dNVNpBlwgJe Eq9fS4CYQkB3brsrAmJyCphKfDlQNIFRYBaS42YhHDcLyXELGJlXMYqmliYXFCel5xrqFSfm Fpfmpesl5+duYoTEypcdjIuPWR1iFOBgVOLhvSBTEC7EmlhWXJl7iFGCg1lJhJfnLFCINyWx siq1KD++qDQntfgQozQHi5I479xd70OEBNITS1KzU1MLUotgskwcnFINjEujJ/LGpD5TlDSv ORfz+V95wOW4D+7tR3reKK1T/CCdcPxb5LOH5pmdj1lnR7eumZR1N4PbwngDcwxf/vldz33/ HrA3Fnf5VFBSf3TlMttnilV/OOsjS6LCny64uGInt/nP12Zl03Tal4YdYFWOd26XPKl4+UIR g849f1F2Gft9HVur1vnMU2Ipzkg01GIuKk4EAPmc/ZaRAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephan, On 06/24/2016 07:16 PM, Stephan Linz wrote: > Cc: Joseph Jezak > Cc: Jörg Sommer > Cc: Mark Rutland > Signed-off-by: Stephan Linz > Acked-by: Rob Herring > Signed-off-by: Jacek Anaszewski > --- > Changes in v6: > - Reorganize v5. > > Changes in v5: > - Keep documentation for the old 'ide-disk' device tree > binding, but mark as deprecated and refer to the new > trigger 'disk-activity'. > > Changes in v4: > - Keep the 'ide-disk' trigger and add a second one > for 'disk-activity'. > > Changes in v3: > - Port to kernel 4.x > - Split into platform independent and dependent parts. > > v2: https://patchwork.ozlabs.org/patch/117485/ > v1: http://dev.gentoo.org/~josejx/ata.patch > --- > Documentation/devicetree/bindings/leds/common.txt | 4 +++- > Documentation/devicetree/bindings/leds/leds-gpio.txt | 4 ++-- > Documentation/laptops/asus-laptop.txt | 2 +- > Documentation/leds/leds-class.txt | 2 +- > 4 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt > index af10678..93ef6e6 100644 > --- a/Documentation/devicetree/bindings/leds/common.txt > +++ b/Documentation/devicetree/bindings/leds/common.txt > @@ -26,7 +26,9 @@ Optional properties for child nodes: > "default-on" - LED will turn on (but for leds-gpio see "default-state" > property in Documentation/devicetree/bindings/gpio/led.txt) > "heartbeat" - LED "double" flashes at a load average based rate > - "ide-disk" - LED indicates disk activity > + "disk-activity" - LED indicates disk activity > + "ide-disk" - LED indicates IDE disk activity (deprecated), > + in new implementations use "disk-activity" > "timer" - LED flashes at a fixed, configurable rate > > - led-max-microamp : Maximum LED supply current in microamperes. This property > diff --git a/Documentation/devicetree/bindings/leds/leds-gpio.txt b/Documentation/devicetree/bindings/leds/leds-gpio.txt > index cbbeb18..5b1b43a 100644 > --- a/Documentation/devicetree/bindings/leds/leds-gpio.txt > +++ b/Documentation/devicetree/bindings/leds/leds-gpio.txt > @@ -33,9 +33,9 @@ Examples: > leds { > compatible = "gpio-leds"; > hdd { > - label = "IDE Activity"; > + label = "Disk Activity"; > gpios = <&mcu_pio 0 GPIO_ACTIVE_LOW>; > - linux,default-trigger = "ide-disk"; > + linux,default-trigger = "disk-activity"; > }; > > fault { > diff --git a/Documentation/laptops/asus-laptop.txt b/Documentation/laptops/asus-laptop.txt > index 79a1bc6..5f28587 100644 > --- a/Documentation/laptops/asus-laptop.txt > +++ b/Documentation/laptops/asus-laptop.txt > @@ -72,7 +72,7 @@ LEDs > echo 1 > /sys/class/leds/asus::mail/brightness > will switch the mail LED on. > You can also know if they are on/off by reading their content and use > - kernel triggers like ide-disk or heartbeat. > + kernel triggers like disk-activity or heartbeat. > > Backlight > --------- > diff --git a/Documentation/leds/leds-class.txt b/Documentation/leds/leds-class.txt > index 44f5e6b..f1f7ec9 100644 > --- a/Documentation/leds/leds-class.txt > +++ b/Documentation/leds/leds-class.txt > @@ -11,7 +11,7 @@ brightness support so will just be turned on for non-zero brightness settings. > The class also introduces the optional concept of an LED trigger. A trigger > is a kernel based source of led events. Triggers can either be simple or > complex. A simple trigger isn't configurable and is designed to slot into > -existing subsystems with minimal additional code. Examples are the ide-disk, > +existing subsystems with minimal additional code. Examples are the disk-activity, > nand-disk and sharpsl-charge triggers. With led triggers disabled, the code > optimises away. > > Applied, thanks. -- Best regards, Jacek Anaszewski