All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Binns <frank.binns@imgtec.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: rufus.hamade@imgtec.com,
	Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 3/6] drm/amd/amdgpu: Set DRIVER_MODESET feature flag at build time
Date: Mon, 27 Jun 2016 10:37:54 +0100	[thread overview]
Message-ID: <5770F3F2.1090000@imgtec.com> (raw)
In-Reply-To: <CADnq5_OXfhO5HwyPG3bxjZ78dfRjOM7r+vooLEDH80Td6Byvfw@mail.gmail.com>

On 24/06/16 23:08, Alex Deucher wrote:
> On Fri, Jun 24, 2016 at 1:15 PM, Frank Binns <frank.binns@imgtec.com> wrote:
>> This flag was being set unconditionally at runtime so just set it at
>> compile time instead.
>>
>> Signed-off-by: Frank Binns <frank.binns@imgtec.com>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>
> Do you want to take this as part of the patch set, or should I apply
> this to my tree?
>
> Alex

This patch is independent of the rest so I'm happy for you to
apply it to your tree.

Thanks
Frank

>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> index f888c01..7fe7f3c 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> @@ -515,7 +515,7 @@ static struct drm_driver kms_driver = {
>>          .driver_features =
>>              DRIVER_USE_AGP |
>>              DRIVER_HAVE_IRQ | DRIVER_IRQ_SHARED | DRIVER_GEM |
>> -           DRIVER_PRIME | DRIVER_RENDER,
>> +           DRIVER_PRIME | DRIVER_RENDER | DRIVER_MODESET,
>>          .dev_priv_size = 0,
>>          .load = amdgpu_driver_load_kms,
>>          .open = amdgpu_driver_open_kms,
>> @@ -590,7 +590,6 @@ static int __init amdgpu_init(void)
>>          DRM_INFO("amdgpu kernel modesetting enabled.\n");
>>          driver = &kms_driver;
>>          pdriver = &amdgpu_kms_pci_driver;
>> -       driver->driver_features |= DRIVER_MODESET;
>>          driver->num_ioctls = amdgpu_max_kms_ioctl;
>>          amdgpu_register_atpx_handler();
>>          /* let modprobe override vga console setting */
>> --
>> 2.7.4
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-06-27  9:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24 17:15 [PATCH v2 0/6] Support render only drivers Frank Binns
2016-06-24 17:15 ` [PATCH 1/6] drm/vmwgfx: Stop checking minor type directly Frank Binns
2016-06-24 22:46   ` Sinclair Yeh
2016-07-12 11:08     ` Daniel Vetter
2016-06-24 17:15 ` [PATCH 2/6] drm: Rename DRM_MINOR_LEGACY to DRM_MINOR_PRIMARY Frank Binns
2016-07-12 11:09   ` Daniel Vetter
2016-06-24 17:15 ` [PATCH 3/6] drm/amd/amdgpu: Set DRIVER_MODESET feature flag at build time Frank Binns
2016-06-24 22:08   ` Alex Deucher
2016-06-27  9:37     ` Frank Binns [this message]
2016-06-27 15:51       ` Alex Deucher
2016-06-24 17:15 ` [PATCH 4/6] drm/qxl: Remove dead code Frank Binns
2016-07-12 11:09   ` Daniel Vetter
2016-06-24 17:15 ` [PATCH v2 5/6] drm: Introduce DRIVER_LEGACY feature Frank Binns
2016-06-24 17:15 ` [PATCH v2 6/6] drm: Separate DRIVER_MODESET and DRIVER_LEGACY Frank Binns
2016-07-12 11:06   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5770F3F2.1090000@imgtec.com \
    --to=frank.binns@imgtec.com \
    --cc=alexdeucher@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=rufus.hamade@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.