Re: [PATCH V2 07/10] arm: vgic: Split vgic_domain_init() functionality into two functions

[Julien Grall <julien.grall@arm.com>]

Hi Shanker,

On 26/06/16 18:48, Shanker Donthineni wrote:
> Separate the code logic that does the registration of vgic_v3/v2 ops
> to a new fucntion domain_vgic_register(). The intention of this

s/fucntion/function/

> separation is to record the required mmio count in vgic_v3/v2_init()
> and pass it to function domain_io_init() in the later patch.

s/the later/a follow-up patch/ or s/the later/the last/. Although I 
prefer the former.

>
> Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
> ---
> Changes since v1:
>    Moved registration of vgic_v3/v2 functionality to a new domain_vgic_register().
>
>   xen/arch/arm/vgic.c | 33 +++++++++++++++++++++------------
>   1 file changed, 21 insertions(+), 12 deletions(-)
>
> diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
> index 5df5f01..7627eff 100644
> --- a/xen/arch/arm/vgic.c
> +++ b/xen/arch/arm/vgic.c
> @@ -88,19 +88,8 @@ static void vgic_rank_init(struct vgic_irq_rank *rank, uint8_t index,
>           rank->vcpu[i] = vcpu;
>   }
>
> -int domain_vgic_init(struct domain *d, unsigned int nr_spis)
> +static int domain_vgic_register(struct domain *d)
>   {
> -    int i;
> -    int ret;
> -
> -    d->arch.vgic.ctlr = 0;
> -
> -    /* Limit the number of virtual SPIs supported to (1020 - 32) = 988  */
> -    if ( nr_spis > (1020 - NR_LOCAL_IRQS) )
> -        return -EINVAL;
> -
> -    d->arch.vgic.nr_spis = nr_spis;
> -
>       switch ( d->arch.vgic.version )
>       {
>   #ifdef CONFIG_HAS_GICV3
> @@ -119,6 +108,26 @@ int domain_vgic_init(struct domain *d, unsigned int nr_spis)
>           return -ENODEV;
>       }
>
> +    return 0;
> +}
> +
> +int domain_vgic_init(struct domain *d, unsigned int nr_spis)
> +{
> +    int i;
> +    int ret;
> +
> +    d->arch.vgic.ctlr = 0;
> +
> +    /* Limit the number of virtual SPIs supported to (1020 - 32) = 988  */
> +    if ( nr_spis > (1020 - NR_LOCAL_IRQS) )
> +        return -EINVAL;
> +
> +    d->arch.vgic.nr_spis = nr_spis;
> +
> +    ret = domain_vgic_register(d);
> +    if ( ret < 0)

Coding style:

if ( ret < 0 )

> +        return ret;
> +
>       spin_lock_init(&d->arch.vgic.lock);
>
>       d->arch.vgic.shared_irqs =
>

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel