All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] raw_bsd: Convert to byte-based interface
Date: Mon, 27 Jun 2016 06:51:08 -0600	[thread overview]
Message-ID: <5771213C.5090209@redhat.com> (raw)
In-Reply-To: <5a03a995-2be3-66cc-89af-c3b4f42c3568@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]

On 06/27/2016 06:19 AM, Paolo Bonzini wrote:
> 
> 
> On 24/06/2016 05:58, Eric Blake wrote:
>> Since the raw format driver is just passing things through, we can
>> do byte-based read and write if the underlying protocol does
>> likewise.
>>
>> There's one tricky part - if we probed the image format, we document
>> that we restrict operations on the initial sector.  Rather than
>> trying to handle a read-modify-write on the first sector, it's
>> easiest to just include in our restrictions that partial writes to
>> the first sector are not permitted.
> 
> Can we just set the alignment to at least 512 if probed?  It's the
> practical guest alignment anyway.

Interesting idea; should be fairly easy to attempt.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

      reply	other threads:[~2016-06-27 12:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24  3:58 [Qemu-devel] [PATCH 0/2] Switch raw NBD to byte-based Eric Blake
2016-06-24  3:58 ` [Qemu-devel] [PATCH 1/2] nbd: Convert to byte-based interface Eric Blake
2016-06-27 12:19   ` Paolo Bonzini
2016-06-24  3:58 ` [Qemu-devel] [PATCH 2/2] raw_bsd: " Eric Blake
2016-06-27 12:19   ` Paolo Bonzini
2016-06-27 12:51     ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5771213C.5090209@redhat.com \
    --to=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.