From: Guenter Roeck <linux@roeck-us.net>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Robin Gong <b38343@freescale.com>,
Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v2 1/2] watchdog: add pretimeout support to the core
Date: Mon, 27 Jun 2016 06:32:36 -0700 [thread overview]
Message-ID: <57712AF4.80104@roeck-us.net> (raw)
In-Reply-To: <20160627093707.GD1602@katana>
On 06/27/2016 02:37 AM, Wolfram Sang wrote:
>
>> Nitpick: If we consider pretimeout == timeout to be invalid, we should reject it here
>> as well. So this should be >=.
>
> I agree to that.
>
>> to the next version. I'd suggest to wait a bit to give Wolfram time to provide input,
>> though.
>
> I liked the is_visible() change right away, so these patches are fine.
> Guenter, what is your take on upstreaming the softdog pretimeout
> support? I'd think it would be good to have for testing purposes. It
> would also help me to upstream the busybox patch for the watchdog
> applet.
>
Sure, but the current patch series doesn't include watchdog_notify_pretimeout(),
or am I missing something ?
Guenter
next prev parent reply other threads:[~2016-06-27 13:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-26 1:01 [PATCH v2 0/2] watchdog: add get/set peretimeout UAPI and internals Vladimir Zapolskiy
2016-06-26 1:01 ` [PATCH v2 1/2] watchdog: add pretimeout support to the core Vladimir Zapolskiy
2016-06-26 2:30 ` Guenter Roeck
2016-06-27 9:37 ` Wolfram Sang
2016-06-27 13:32 ` Guenter Roeck [this message]
2016-06-27 15:33 ` Wolfram Sang
2016-06-27 20:14 ` Guenter Roeck
2016-06-26 1:01 ` [PATCH v2 2/2] fs: compat_ioctl: add pretimeout functions for watchdogs Vladimir Zapolskiy
2016-06-26 2:30 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57712AF4.80104@roeck-us.net \
--to=linux@roeck-us.net \
--cc=b38343@freescale.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=vladimir_zapolskiy@mentor.com \
--cc=wim@iguana.be \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.