From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751919AbcF0Nj4 (ORCPT ); Mon, 27 Jun 2016 09:39:56 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:48901 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751862AbcF0Njy (ORCPT ); Mon, 27 Jun 2016 09:39:54 -0400 Subject: Re: [PATCHv3 1/2] usb: USB Type-C connector class To: Heikki Krogerus , Rajaram R References: <1466520711-125758-1-git-send-email-heikki.krogerus@linux.intel.com> <1466520711-125758-2-git-send-email-heikki.krogerus@linux.intel.com> <20160627095120.GC20801@kuha.fi.intel.com> <20160627121321.GD20801@kuha.fi.intel.com> Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Oliver Neukum From: Guenter Roeck Message-ID: <57712CA2.1020408@roeck-us.net> Date: Mon, 27 Jun 2016 06:39:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160627121321.GD20801@kuha.fi.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/27/2016 05:13 AM, Heikki Krogerus wrote: > Hi, > > On Mon, Jun 27, 2016 at 03:51:08PM +0530, Rajaram R wrote: >> May be I am missing user or usage of the driver.. I see this driver is >> providing limited information of the Type-C connectors or the port >> partner > > Yes, this interface can't provide directly information received from > PD commands like Discover Identity. We will have to present the > partners even when USB PD is not supported and in a consistent > fashion. Some details will be available in any case indirectly. Like > if there are modes, there will be devices presenting them, and the > product type in case of partners will be the partner type. > > But there are a couple of attributes I have been thinking about adding > for the partners: > > supported_data_roles > supports_usb_power_delivery > > The supported data roles would respond bits 30 and 31 of the ID Header > VDO. But when the partner does not support USB PD, we will have to > report "unknown" in it. > Or make the attribute invisible in that case. > Oliver, Guenter! How do you guys feel about those? Is there any use > for them? > Definitely good for debugging and informational. On the top of my head, I don't immediately see what a user would do with it, though, but then it would not hurt either to have the information. I keep wondering if it would make sense to directly expose the ID header VDO, similar to the alternate mode VDOs, in the partner node. Guenter > >> On Mon, Jun 27, 2016 at 3:21 PM, Heikki Krogerus >> wrote: >>> On Fri, Jun 24, 2016 at 07:54:12PM +0530, Rajaram R wrote: >>>> On Tue, Jun 21, 2016 at 8:21 PM, Heikki Krogerus >>>> wrote: >>>>> The purpose of USB Type-C connector class is to provide >>>>> unified interface for the user space to get the status and >>>>> basic information about USB Type-C connectors on a system, >>>> >>>> Since we are defining this is as a unified interface for user space, >>>> will the interface include identity details of local port and peer. >>>> Or am I over looking something ? >>> >>> By peer, do you mean the partners? Sorry but could you elaborate the >>> question? > > > Thanks, >