From: Hans Verkuil <hverkuil@xs4all.nl>
To: Andrey Utkin <andrey_utkin@fastmail.com>
Cc: Ismael Luceno <ismael@iodev.co.uk>,
linux-media@vger.kernel.org,
Andrey Utkin <andrey.utkin@corp.bluecherry.net>
Subject: Re: [PATCH v2 1/2] solo6x10: Set FRAME_BUF_SIZE to 200KB
Date: Tue, 28 Jun 2016 13:58:15 +0200 [thread overview]
Message-ID: <57726657.3040802@xs4all.nl> (raw)
In-Reply-To: <20160628114809.GF31802@acer>
On 06/28/16 13:48, Andrey Utkin wrote:
> On Mon, Jun 27, 2016 at 11:12:42AM +0200, Hans Verkuil wrote:
>> Andrey,
>>
>> Since you are the original author, can you give me your Signed-off-by line?
>
> No, as increasing buffer size by few kilobytes doesn't change anything. I've
> increased it from 200 to 204, then found new occurances of the issue,
> then increased it again and again by few kilobytes. Then I got that this
> is not a (nice) solution, and have never came back to this. Maybe
> doubling current buffer size would make users forget about this, but I'm
> not sure maintainers would be glad with such patch.
I don't care. Right now it doesn't work. The cause is that the buffers are
too small to handle the worst-case situation. So if doubling the size makes
it work, then that's perfectly OK. Memory is cheap these days. If it will
fail, then that's much worse than consuming a few meg more.
Ideally you can calculate what the worst-case size is, but I expect that to
be quite difficult if not impossible.
Regards,
Hans
prev parent reply other threads:[~2016-06-28 11:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 16:21 [PATCH v2 1/2] solo6x10: Set FRAME_BUF_SIZE to 200KB Ismael Luceno
2016-05-04 16:21 ` [PATCH v2 2/2] solo6x10: Simplify solo_enum_ext_input Ismael Luceno
2016-05-04 21:14 ` [PATCH v2 1/2] solo6x10: Set FRAME_BUF_SIZE to 200KB Andrey Utkin
2016-05-04 23:24 ` Ismael Luceno
2016-06-27 9:12 ` Hans Verkuil
2016-06-28 11:48 ` Andrey Utkin
2016-06-28 11:58 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57726657.3040802@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=andrey.utkin@corp.bluecherry.net \
--cc=andrey_utkin@fastmail.com \
--cc=ismael@iodev.co.uk \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.