From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHtv8-0008Fw-CP for qemu-devel@nongnu.org; Tue, 28 Jun 2016 10:23:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHtv0-0005bb-Ho for qemu-devel@nongnu.org; Tue, 28 Jun 2016 10:23:22 -0400 References: <1466681836-1123-1-git-send-email-den@openvz.org> <57725DB0.50503@openvz.org> From: Eric Blake Message-ID: <5772883F.5070901@redhat.com> Date: Tue, 28 Jun 2016 08:22:55 -0600 MIME-Version: 1.0 In-Reply-To: <57725DB0.50503@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ev3EpakHU3PiFOFnOn7dXtrALsCR9j0eL" Subject: Re: [Qemu-devel] [PATCH 1/1] block: fix return code for partial write for Linux AIO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Kevin Wolf , Pavel Borzenkov , Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ev3EpakHU3PiFOFnOn7dXtrALsCR9j0eL From: Eric Blake To: "Denis V. Lunev" , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Kevin Wolf , Pavel Borzenkov , Max Reitz Message-ID: <5772883F.5070901@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/1] block: fix return code for partial write for Linux AIO References: <1466681836-1123-1-git-send-email-den@openvz.org> <57725DB0.50503@openvz.org> In-Reply-To: <57725DB0.50503@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/28/2016 05:21 AM, Denis V. Lunev wrote: > On 06/23/2016 02:37 PM, Denis V. Lunev wrote: >> Partial write most likely means that there is not space rather than >> "something wrong happens". Thus it would be more natural to return >> ENOSPC rather than EINVAL. >> >> The problem actually happens with NBD server, which has reported EINVA= L >> rather then ENOSPC on the first error using its protocol, which makes >> report to the user wrong. I'm not stating that this patch is wrong, but I'm also wondering if NBD code needs to be patched (the NBD protocol specifically recommends ENOSPC rather than EINVAL on attempts to write larger than size). In fact, commit 29b6c3b3 may have been that fix. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Ev3EpakHU3PiFOFnOn7dXtrALsCR9j0eL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXcog/AAoJEKeha0olJ0Nqz18IAKALXU4JceZr7YW+quvmdFqe CkD8SBEcnqeBErUDQ/AuUT3BV+sn+N2pc7jmfdO8bG5cZYgYhc52AEtUxGPlYzR2 V5gObeGH3xIvswi3dNmD0dsYgKyQ4o/iINQVqkXB3EYBdMxXdmO3aDQWlU5HUMUX GV9KBmePGQzh3VjIlHjCuEfpigPrPeK0MhLZXlqAmflSYBIbpBP/ayfTnlD0yo54 zUAENVcgTrJmryM6ZDG/Br3739TegZmQZ4Ke6kWXVmaLDmmap1eN1Usk0CE1lj/7 hEGx+Ipi0B6AMgze6Y+Y0wzMs7paRKhcdhKUUM+KWjgePuNLCRxyyrYS/XH3zi0= =n8sG -----END PGP SIGNATURE----- --Ev3EpakHU3PiFOFnOn7dXtrALsCR9j0eL--