From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Tue, 28 Jun 2016 17:00:37 +0200 Subject: [U-Boot] [PATCH] arm: mmc: increase MMC SDHCI read status timeout In-Reply-To: <1467063821-15900-1-git-send-email-steve.rae@raedomain.com> References: <1467063821-15900-1-git-send-email-steve.rae@raedomain.com> Message-ID: <57729115.8040903@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Steve, On 27.06.2016 23:43, Steve Rae wrote: > Otherwise, ocassionally see errors like this: > Flashing sparse image at offset 2078720 > Flashing Sparse Image > sdhci_send_command: Timeout for status update! > mmc fail to send stop cmd > write_sparse_image: Write failed, block #2181088 [0] > > This does not affect the actual writing speed, which is controlled by > the default value: > CONFIG_SDHCI_CMD_DEFAULT_TIMEOUT > > It only increases the retries when reading: > SDHCI_INT_STATUS > to avoid the timeout error. > > Signed-off-by: Steve Rae > --- > as per the discussion in: > http://lists.denx.de/pipermail/u-boot/2016-June/258966.html > this supercedes: > http://patchwork.ozlabs.org/patch/615994/ IIRC, I've suggested to move SDHCI_CMD_DEFAULT_TIMEOUT to Kconfig and use the old value as default value. So that you can overwrite it for your board / platform via your defconfig. But I have no strong feelings here - your current version also works for me and does not "clutter" the Kconfig subsystem with too many values. So: Reviewed-by: Stefan Roese Thanks, Stefan > drivers/mmc/sdhci.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c > index 5c71ab8..aa4cd4f 100644 > --- a/drivers/mmc/sdhci.c > +++ b/drivers/mmc/sdhci.c > @@ -127,6 +127,7 @@ static int sdhci_transfer_data(struct sdhci_host *host, struct mmc_data *data, > #define CONFIG_SDHCI_CMD_MAX_TIMEOUT 3200 > #endif > #define CONFIG_SDHCI_CMD_DEFAULT_TIMEOUT 100 > +#define CONFIG_SDHCI_READ_STATUS_TIMEOUT 1000 > > static int sdhci_send_command(struct mmc *mmc, struct mmc_cmd *cmd, > struct mmc_data *data) > @@ -243,9 +244,9 @@ static int sdhci_send_command(struct mmc *mmc, struct mmc_cmd *cmd, > if (stat & SDHCI_INT_ERROR) > break; > } while (((stat & mask) != mask) && > - (get_timer(start) < CONFIG_SDHCI_CMD_DEFAULT_TIMEOUT)); > + (get_timer(start) < CONFIG_SDHCI_READ_STATUS_TIMEOUT)); > > - if (get_timer(start) >= CONFIG_SDHCI_CMD_DEFAULT_TIMEOUT) { > + if (get_timer(start) >= CONFIG_SDHCI_READ_STATUS_TIMEOUT) { > if (host->quirks & SDHCI_QUIRK_BROKEN_R1B) > return 0; > else { > Viele Gr??e, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de