From: Tony <tony.makkiel@daqri.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-leds@vger.kernel.org, j.anaszewski@samsung.com,
rpurdie@rpsys.net, rjw@rjwysocki.net, lenb@kernel.org
Subject: Re: [PATCH v6 1/1] leds: LED driver for TI LP3952 6-Channel Color LED
Date: Tue, 28 Jun 2016 17:01:35 +0100 [thread overview]
Message-ID: <57729F5F.9000809@daqri.com> (raw)
In-Reply-To: <20160628144254.GL1711@lahna.fi.intel.com>
On 28/06/16 15:42, Mika Westerberg wrote:
> On Tue, Jun 28, 2016 at 10:44:25AM +0100, Tony Makkiel wrote:
>> +#ifdef CONFIG_ACPI
>> +static const struct acpi_device_id lp3952_acpi_match[] = {
>> + {LP3952_ACPI_NAME, 0},
>> + {}
>> +};
>> +
>> +MODULE_DEVICE_TABLE(acpi, lp3952_acpi_match);
>> +#endif
>
> Do you actually have ACPI system with this device included or are you
> just making this up? If there is no such system please consider dropping
> ACPI probing support from the driver. It can be added later if actually
> found on some real system.
Yes, I do have an ACPI system :).
>
prev parent reply other threads:[~2016-06-28 16:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 9:44 [PATCH v6 1/1] leds: LED driver for TI LP3952 6-Channel Color LED Tony Makkiel
2016-06-28 11:29 ` Jacek Anaszewski
2016-06-28 14:42 ` Mika Westerberg
2016-06-28 16:01 ` Tony [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57729F5F.9000809@daqri.com \
--to=tony.makkiel@daqri.com \
--cc=j.anaszewski@samsung.com \
--cc=lenb@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.