From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752440AbcF1STG (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Jun 2016 14:19:06 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:46039 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752060AbcF1STE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Jun 2016 14:19:04 -0400
Subject: Re: [RESEND][PATCH 2/2] arm64: dts: hi6220: Add pl031 RTC support
To: John Stultz <john.stultz@linaro.org>, lkml <linux-kernel@vger.kernel.org>
References: <1466714368-4813-1-git-send-email-john.stultz@linaro.org>
 <1466714368-4813-3-git-send-email-john.stultz@linaro.org>
CC: Zhangfei Gao <zhangfei.gao@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@codeaurora.org>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Guodong Xu <guodong.xu@linaro.org>,
        <xuwei5@hisilicon.com>
From: Wei Xu <xuwei5@hisilicon.com>
Message-ID: <5772BF7A.3020700@hisilicon.com>
Date: Tue, 28 Jun 2016 19:18:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <1466714368-4813-3-git-send-email-john.stultz@linaro.org>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.203.181.152]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020202.5772BF8E.0027,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 1d79d10a7fdc44dc41f77d18bb6bc9c2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi John,

On 23/06/2016 21:39, John Stultz wrote:
> From: Zhangfei Gao <zhangfei.gao@linaro.org>
> 
> Add pl031 rtc0 and rtc1 support to hi6220 dtsi
> 
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: Guodong Xu <guodong.xu@linaro.org>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> [jstultz: Forward ported and tweaked commit description,
>  added rtc1 entry as suggested by Guodong]
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 189d215..12510b5 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -336,6 +336,22 @@
>  			clock-names = "timer1", "timer2", "apb_pclk";
>  		};
>  
> +		rtc0: rtc@f8003000 {
> +			compatible = "arm,pl031", "arm,primecell";
> +			reg = <0x0 0xf8003000 0x0 0x1000>;
> +			interrupts = <0 12 4>;
> +			clocks = <&ao_ctrl HI6220_RTC0_PCLK>;
> +			clock-names = "apb_pclk";
> +		};
> +
> +		 rtc1: rtc@f8004000 {

Sorry for the late reply.
Thanks for the patch!
Except the indent of the rtc1, the others is fine to me.
Acked-by: Wei Xu <xuwei5@hisilicon.com>

As what Stephen said in the cover letter works for me.

Best Regards,
Wei

> +			compatible = "arm,pl031", "arm,primecell";
> +			reg = <0x0 0xf8004000 0x0 0x1000>;
> +			interrupts = <0 8 4>;
> +			clocks = <&ao_ctrl HI6220_RTC1_PCLK>;
> +			clock-names = "apb_pclk";
> +		};
> +
>  		pmx0: pinmux@f7010000 {
>  			compatible = "pinctrl-single";
>  			reg = <0x0 0xf7010000  0x0 0x27c>;
>